MD Settings: Display a message when no other search engines exist.

MD Settings: Display a message when no other search engines exist.

BUG=619790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2691033008
Cr-Commit-Position: refs/heads/master@{#451060}
Committed: https://chromium.googlesource.com/chromium/src/+/b4f09b9a3acecf253d000ee1eca9c84f8556b284

[dpapad, 2017-02-15 23:01:48]

Description was changed from

==========
MD Settings: Display a message when no other search engines exist.

BUG=619790
==========

to

==========
MD Settings: Display a message when no other search engines exist.

BUG=619790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-15 23:56:49]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-16 01:02:11]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2017-02-16 01:02:12]

After screenshots: http://imgur.com/a/EGxSp

[commit-bot: I haz the power, 2017-02-16 02:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:01:28]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[tommycli, 2017-02-16 02:09:51]

lgtm thanks

https://codereview.chromium.org/2691033008/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2691033008/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1505:
{"searchEnginesNoOther", IDS_SETTINGS_SEARCH_ENGINES_NO_OTHER_ENGINES},
nit: more verbose, but "searchEnginesNoOtherEngines" would be more immediately
clear to me.

[dpapad, 2017-02-16 03:26:38]

https://codereview.chromium.org/2691033008/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2691033008/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1505:
{"searchEnginesNoOther", IDS_SETTINGS_SEARCH_ENGINES_NO_OTHER_ENGINES},
On 2017/02/16 at 02:09:51, tommycli wrote:
> nit: more verbose, but "searchEnginesNoOtherEngines" would be more immediately
clear to me.

Done.

[dpapad, 2017-02-16 03:26:40]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-02-16 03:26:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2691033008/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2017-02-16 03:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:01:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:01:28]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dpapad, 2017-02-16 18:08:37]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:46:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487268517749320,
"parent_rev": "f955fb9cd61c9b6b246a9484a60068eb38c54aec", "commit_rev":
"b4f09b9a3acecf253d000ee1eca9c84f8556b284"}

[commit-bot: I haz the power, 2017-02-16 19:47:17]

Description was changed from

==========
MD Settings: Display a message when no other search engines exist.

BUG=619790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Display a message when no other search engines exist.

BUG=619790
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2691033008
Cr-Commit-Position: refs/heads/master@{#451060}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4f09b9a3acecf253d000ee1eca9...
==========

[commit-bot: I haz the power, 2017-02-16 19:47:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b4f09b9a3acecf253d000ee1eca9...