Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5603)

Unified Diff: chrome/test/data/webui/settings/search_engines_page_test.js

Issue 2691033008: MD Settings: Display a message when no other search engines exist. (Closed)
Patch Set: Nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/search_engines_page_test.js
diff --git a/chrome/test/data/webui/settings/search_engines_page_test.js b/chrome/test/data/webui/settings/search_engines_page_test.js
index 5c628d8d38030d158a41545817e6ff729ab51b21..36be7c2b314606427029323833b8a7f91c23eaee 100644
--- a/chrome/test/data/webui/settings/search_engines_page_test.js
+++ b/chrome/test/data/webui/settings/search_engines_page_test.js
@@ -293,6 +293,7 @@ cr.define('settings_search_engines_page', function() {
PolymerTest.clearBody();
page = document.createElement('settings-search-engines-page');
document.body.appendChild(page);
+ return browserProxy.whenCalled('getSearchEnginesList');
});
teardown(function() { page.remove(); });
@@ -300,31 +301,44 @@ cr.define('settings_search_engines_page', function() {
// Tests that the page is querying and displaying search engine info on
// startup.
test('Initialization', function() {
- return browserProxy.whenCalled('getSearchEnginesList').then(function() {
- var searchEnginesLists = Polymer.dom(page.shadowRoot).
- querySelectorAll('settings-search-engines-list');
- assertEquals(2, searchEnginesLists.length);
-
- // Note: iron-list may create hidden children, so test the length
- // if IronList.items instead of the child nodes.
- Polymer.dom.flush();
- var defaultsList = searchEnginesLists[0];
- var defaultsEntries = Polymer.dom(defaultsList.shadowRoot).
- querySelector('iron-list').items;
- assertEquals(
- searchEnginesInfo.defaults.length, defaultsEntries.length);
-
- var othersList = searchEnginesLists[1];
- var othersEntries = Polymer.dom(othersList.shadowRoot).
- querySelector('iron-list').items;
- assertEquals(
- searchEnginesInfo.others.length, othersEntries.length);
-
- var extensionEntries = Polymer.dom(page.shadowRoot).
- querySelector('iron-list').items;
- assertEquals(
- searchEnginesInfo.extensions.length, extensionEntries.length);
+ var searchEnginesLists = page.shadowRoot.
+ querySelectorAll('settings-search-engines-list');
+ assertEquals(2, searchEnginesLists.length);
+
+ // Note: iron-list may create hidden children, so test the length
+ // if IronList.items instead of the child nodes.
+ Polymer.dom.flush();
+ var defaultsList = searchEnginesLists[0];
+ var defaultsEntries = Polymer.dom(defaultsList.shadowRoot).
+ querySelector('iron-list').items;
+ assertEquals(
+ searchEnginesInfo.defaults.length, defaultsEntries.length);
+
+ var othersList = searchEnginesLists[1];
+ var othersEntries = Polymer.dom(othersList.shadowRoot).
+ querySelector('iron-list').items;
+ assertEquals(
+ searchEnginesInfo.others.length, othersEntries.length);
+
+ var extensionEntries = Polymer.dom(page.shadowRoot).
+ querySelector('iron-list').items;
+ assertEquals(
+ searchEnginesInfo.extensions.length, extensionEntries.length);
+ });
+
+ // Test that the "no other search engines" message is shown/hidden as
+ // expected.
+ test('NoOtherSearchEnginesMessage', function() {
+ var message = page.root.querySelector('#noOtherEngines');
+ assertTrue(!!message);
+ assertFalse(message.hasAttribute('hidden'));
+
+ cr.webUIListenerCallback('search-engines-changed', {
+ defaults: [],
+ others: [createSampleSearchEngine()],
+ extensions: [],
});
+ assertTrue(message.hasAttribute('hidden'));
});
// Tests that the add search engine dialog opens when the corresponding
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698