Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2691023003: Fix timeout in rasterize_and_record_micro benchmarks (Closed)

Created:
3 years, 10 months ago by perezju
Modified:
3 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix timeout in rasterize_and_record_micro benchmarks A bug was introduced when migrating to the v2 API to execute JavaScript snippets in Telemetry. The old timeout used inconsistent defaults on different methods, and the migration caused the timeout to drop from 90 to 60 seconds. Rather than relying on an unseen defualt, specify an explicit timeout on the non-obvious expression that takes a long time to evaluate. TBR=nednguyen@google.com BUG=691751 Review-Url: https://codereview.chromium.org/2691023003 Cr-Commit-Position: refs/heads/master@{#450325} Committed: https://chromium.googlesource.com/chromium/src/+/58b5ae9d8d96fd72374c5ee63a7c8ad358eec9e8

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/measurements/rasterize_and_record_micro.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
perezju
3 years, 10 months ago (2017-02-14 10:56:23 UTC) #2
perezju
TBR'ing to get benchmark unstuck.
3 years, 10 months ago (2017-02-14 10:56:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691023003/20001
3 years, 10 months ago (2017-02-14 10:57:16 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 11:54:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58b5ae9d8d96fd72374c5ee63a7c...

Powered by Google App Engine
This is Rietveld 408576698