Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 2691023003: Fix timeout in rasterize_and_record_micro benchmarks (Closed)
Patch Set: add comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/rasterize_and_record_micro.py
diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py
index ecf5cf7d16b07ad6ebde764d71d3dc26d16bb332..3d3aaa8744042219fbcf8e05c5e72a4df064b258 100644
--- a/tools/perf/measurements/rasterize_and_record_micro.py
+++ b/tools/perf/measurements/rasterize_and_record_micro.py
@@ -52,7 +52,9 @@ class RasterizeAndRecordMicro(legacy_page_test.LegacyPageTest):
record_repeat_count=self._record_repeat,
rasterize_repeat_count=self._rasterize_repeat)
- benchmark_id = tab.EvaluateJavaScript2('window.benchmark_results.id')
+ # Evaluating this expression usually takes between 60 and 90 seconds.
+ benchmark_id = tab.EvaluateJavaScript2(
+ 'window.benchmark_results.id', timeout=self._timeout)
if not benchmark_id:
raise legacy_page_test.MeasurementFailure(
'Failed to schedule rasterize_and_record_micro')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698