Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2690983002: [csa] Make CSA::Assert depend on --debug-code. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Make CSA::Assert depend on --debug-code. This way it's possible to disable Assert() even in Debug builds via --nodebug-code. R=danno@chromium.org BUG=v8:5268 Review-Url: https://codereview.chromium.org/2690983002 Cr-Commit-Position: refs/heads/master@{#43143} Committed: https://chromium.googlesource.com/v8/v8/+/165b411f5f86c9964d345d5a012d8f9304a11c93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +28 lines, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-13 08:56:46 UTC) #1
danno
lgtm
3 years, 10 months ago (2017-02-13 09:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690983002/1
3 years, 10 months ago (2017-02-13 09:05:19 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 09:17:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/165b411f5f86c9964d345d5a012d8f9304a...

Powered by Google App Engine
This is Rietveld 408576698