Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2690853004: [builtins] Add support for ExternalOneByteStrings to StringEqual. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Add support for ExternalOneByteStrings to StringEqual. The StringEqual builtin can now deal with ExternalOneByteStrings without going to the runtime. It still needs to go to the runtime if the external string is short, i.e. if the resource data pointer is not cached. R=yangguo@chromium.org BUG=v8:4913 Review-Url: https://codereview.chromium.org/2690853004 Cr-Commit-Position: refs/heads/master@{#43152} Committed: https://chromium.googlesource.com/v8/v8/+/949d65252dcb9aca82093c2e9d945e50a4fcc070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -20 lines) Patch
M src/builtins/builtins-string.cc View 3 chunks +56 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-13 09:34:19 UTC) #1
Yang
On 2017/02/13 09:34:19, Benedikt Meurer wrote: lgtm.
3 years, 10 months ago (2017-02-13 10:41:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690853004/1
3 years, 10 months ago (2017-02-13 10:42:13 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 10:43:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/949d65252dcb9aca82093c2e9d945e50a4f...

Powered by Google App Engine
This is Rietveld 408576698