Move stripping of debug symbols on linux behind a flag

Move stripping of debug symbols on linux behind a flag

BUG=603286
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2690943007
Cr-Commit-Position: refs/heads/master@{#451971}
Committed: https://chromium.googlesource.com/chromium/src/+/bf73428a02025c24fb2377b234eff6ca80bfbc32

[jochen (gone - plz use gerrit), 2017-02-15 09:36:52]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 09:37:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 13:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 13:22:45]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-02-15 22:48:56]

lgtm

https://codereview.chromium.org/2690943007/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2690943007/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:97: strip_absolute_paths_from_debug_symbols =
false
Can you add a comment above this (inside the condition) that explains why
somebody might want to use this?

[Dirk Pranke, 2017-02-16 03:45:06]

No lgtm.

We shouldn't land this without also landing a change to the buildbot configs to
disable this, else we'll bork our swarming hit rates, I think.

Maybe make this conditional on symbol_level==2 ? Or modify mb_config.pyl so that
the "minimal_symbols" config also sets this?

[jochen (gone - plz use gerrit), 2017-02-16 09:24:37]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 09:25:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 11:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 11:10:09]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-16 12:33:03]

jochen@chromium.org changed reviewers:
+ dpranke@chromium.org

[jochen (gone - plz use gerrit), 2017-02-16 12:33:03]

ptal

[jochen (gone - plz use gerrit), 2017-02-20 09:59:41]

friendly ping

[Dirk Pranke, 2017-02-21 21:22:56]

LGTM.

I can't remember ... gn doesn't complain if you set a build arg but it isn't
actually used on a given platform, as long as the build arg exists, does it?

[jochen (gone - plz use gerrit), 2017-02-22 08:17:50]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-22 08:17:50]

apparently not

[jochen (gone - plz use gerrit), 2017-02-22 08:17:51]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2690943007/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2017-02-22 08:19:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:14:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487751470174300,
"parent_rev": "4bec0d7dc53aa20a83fbd1b4e6bf097b5ff4dded", "commit_rev":
"bf73428a02025c24fb2377b234eff6ca80bfbc32"}

[commit-bot: I haz the power, 2017-02-22 10:14:52]

Description was changed from

==========
Move stripping of debug symbols on linux behind a flag

BUG=603286
R=brettw@chromium.org
==========

to

==========
Move stripping of debug symbols on linux behind a flag

BUG=603286
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2690943007
Cr-Commit-Position: refs/heads/master@{#451971}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf73428a02025c24fb2377b234ef...
==========

[commit-bot: I haz the power, 2017-02-22 10:14:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bf73428a02025c24fb2377b234ef...