Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2690943007: Move stripping of debug symbols on linux behind a flag (Closed)
Patch Set: updates Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 069f10b98123f4560bee01bcdaaea8cf674e22e3..3b31bd75744c0413754ede71df2f8d155b41706b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -92,6 +92,9 @@ declare_args() {
# Optimize for coverage guided fuzzing (balance between speed and number of
# branches)
optimize_for_fuzzing = false
+
+ # Optimize symbol files for maximizing goma cache hit rate.
+ strip_absolute_paths_from_debug_symbols = false
}
if (is_clang && !is_nacl) {
@@ -425,7 +428,7 @@ config("compiler") {
# clang-cl (used if is_win) doesn't expose this flag.
# Currently disabled for nacl since its toolchain lacks this flag (too old).
# TODO(zforman): Once nacl's toolchain is updated, remove check.
- if (is_clang && is_linux) {
+ if (is_clang && is_linux && strip_absolute_paths_from_debug_symbols) {
absolute_path = rebase_path("//.")
cflags += [ "-fdebug-prefix-map=$absolute_path=." ]
}
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698