Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2690943002: Revert of binding: Changes the association among global-proxy/global/window-instance. (Closed)

Created:
3 years, 10 months ago by Yuki
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of binding: Changes the association among global-proxy/global/window-instance. (patchset #15 id:270001 of https://codereview.chromium.org/2617733004/ ) Reason for revert: This CL is suspicious to be causing crashes: https://crbug.com/691269 Original issue's description: > binding: Changes the association among global-proxy/global/window-instance. > > Since V8 now supports internal fields for the global proxy objects, > let's change the mappings among global proxy object / global object / > C++ instance in Blink. > > With this CL, a global proxy object and C++ instance point to each > other, and a global object points to the C++ instance (without > reverse pointer). > > Note that this CL makes one big difference. For non-window objects, > Blink objects always live longer than V8 wrappers. This CL > introduces an exception; DOMWindow may be collected before the V8 > wrapper object gets collected because the V8 wrapper is the global > proxy object which remains the same while navigations. > > BUG=675872 > > Review-Url: https://codereview.chromium.org/2617733004 > Cr-Commit-Position: refs/heads/master@{#449616} > Committed: https://chromium.googlesource.com/chromium/src/+/76ec9e6ea20fb4a3c1f242e39abea0067afd235a TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=675872, 691269 Review-Url: https://codereview.chromium.org/2690943002 Cr-Commit-Position: refs/heads/master@{#449919} Committed: https://chromium.googlesource.com/chromium/src/+/a8e0f8228466461fb0dbbce6eb4373625a39b787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -125 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/defaultView-on-detached-document.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/defaultView-on-detached-document-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 4 chunks +3 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 2 chunks +9 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/ToV8.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 3 chunks +74 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 3 chunks +3 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +10 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Yuki
Created Revert of binding: Changes the association among global-proxy/global/window-instance.
3 years, 10 months ago (2017-02-13 06:53:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690943002/1
3 years, 10 months ago (2017-02-13 06:53:20 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-13 06:54:19 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 08:34:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8e0f8228466461fb0dbbce6eb43...

Powered by Google App Engine
This is Rietveld 408576698