DescriptionRevert of binding: Changes the association among global-proxy/global/window-instance. (patchset #15 id:270001 of https://codereview.chromium.org/2617733004/ )
Reason for revert:
This CL is suspicious to be causing crashes: https://crbug.com/691269
Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance.
>
> Since V8 now supports internal fields for the global proxy objects,
> let's change the mappings among global proxy object / global object /
> C++ instance in Blink.
>
> With this CL, a global proxy object and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference. For non-window objects,
> Blink objects always live longer than V8 wrappers. This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy object which remains the same while navigations.
>
> BUG=675872
>
> Review-Url: https://codereview.chromium.org/2617733004
> Cr-Commit-Position: refs/heads/master@{#449616}
> Committed: https://chromium.googlesource.com/chromium/src/+/76ec9e6ea20fb4a3c1f242e39abea0067afd235a
TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675872, 691269
Review-Url: https://codereview.chromium.org/2690943002
Cr-Commit-Position: refs/heads/master@{#449919}
Committed: https://chromium.googlesource.com/chromium/src/+/a8e0f8228466461fb0dbbce6eb4373625a39b787
Patch Set 1 #Messages
Total messages: 8 (4 generated)
|