third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h - Issue 2690943002: Revert of binding: Changes the association among global-proxy/global/window-instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2690943002: Revert of binding: Changes the association among global-proxy/global/window-instance. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

index 86f7ae5098299f762aa7592a496f247be059e03b..cc970e70ecff0d9c37674b30f0c53cc4075e405e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

@@ -128,14 +128,6 @@

return true;

}

- // Dissociates the wrapper, if any, from this instance.

- void unsetWrapperIfAny() {

- if (containsWrapper()) {

- m_mainWorldWrapper.Reset();

- WrapperTypeInfo::wrapperDestroyed();

- }

bool isEqualTo(const v8::Local<v8::Object>& other) const {

return m_mainWorldWrapper == other;

}