Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2690753002: cc: Move render surface ownership from layers to the effect tree (Closed)

Created:
3 years, 10 months ago by ajuma
Modified:
3 years, 10 months ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move render surface ownership from layers to the effect tree This moves ownership of render surfaces from LayerImpl to the effect tree. This is a step towards removing the assumption that each render surface has a corresponding layer. After this, the main remaining step is replacing iteration over the render surface layer list with iteration over the effect tree and layer list. BUG=611883 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2690753002 Cr-Commit-Position: refs/heads/master@{#452479} Committed: https://chromium.googlesource.com/chromium/src/+/6b96f4cc4a05c50afd3091cf3bbdd0ecd8990cdf

Patch Set 1 #

Patch Set 2 : Unit tests pass #

Patch Set 3 : Fix formatting #

Patch Set 4 : Fix comment #

Patch Set 5 : Replace repeated calls to LayerImpl::render_surface #

Total comments: 3

Patch Set 6 : Only update surfaces when can_render_to_separate_surface changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -242 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 5 chunks +13 lines, -32 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M cc/layers/layer_iterator.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/render_surface_impl.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 2 3 4 5 6 chunks +19 lines, -69 lines 0 comments Download
M cc/trees/effect_node.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/effect_node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +26 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 1 chunk +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 8 chunks +8 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 6 chunks +31 lines, -21 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 2 3 4 5 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 3 4 5 3 chunks +23 lines, -6 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 3 4 5 5 chunks +84 lines, -48 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (26 generated)
ajuma
https://codereview.chromium.org/2690753002/diff/140001/cc/layers/layer_impl.h File cc/layers/layer_impl.h (right): https://codereview.chromium.org/2690753002/diff/140001/cc/layers/layer_impl.h#newcode236 cc/layers/layer_impl.h:236: RenderSurfaceImpl* render_surface() const; This needs to be renamed since ...
3 years, 10 months ago (2017-02-21 15:16:50 UTC) #18
jaydasika
https://codereview.chromium.org/2690753002/diff/140001/cc/trees/property_tree.cc File cc/trees/property_tree.cc (right): https://codereview.chromium.org/2690753002/diff/140001/cc/trees/property_tree.cc#newcode992 cc/trees/property_tree.cc:992: void EffectTree::UpdateRenderSurfaces(LayerTreeImpl* layer_tree_impl, I am confused. Why do we ...
3 years, 10 months ago (2017-02-22 01:29:50 UTC) #21
ajuma
PTAL https://codereview.chromium.org/2690753002/diff/140001/cc/trees/property_tree.cc File cc/trees/property_tree.cc (right): https://codereview.chromium.org/2690753002/diff/140001/cc/trees/property_tree.cc#newcode992 cc/trees/property_tree.cc:992: void EffectTree::UpdateRenderSurfaces(LayerTreeImpl* layer_tree_impl, On 2017/02/22 01:29:50, jaydasika wrote: ...
3 years, 10 months ago (2017-02-22 22:07:00 UTC) #24
jaydasika
lgtm
3 years, 10 months ago (2017-02-22 23:20:06 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690753002/160001
3 years, 10 months ago (2017-02-23 14:03:22 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 14:07:52 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/6b96f4cc4a05c50afd3091cf3bbd...

Powered by Google App Engine
This is Rietveld 408576698