Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2690563002: Full runtime cloud policy proto will not be generated by default.. (Closed)

Created:
3 years, 10 months ago by Ramin Halavati
Modified:
3 years, 10 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, Peter Kasting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Full runtime cloud policy proto will not be generated by default.. Recent CL (https://codereview.chromium.org/2645053003) had added a new output to cloud policy proto script generator which was suitable for full runtime compilation. This is probably causing a race condition in compiling when this output is not required. This CL separates the codes responsible for generating the two outputs and the second one is generated only if it is explicitly requested. BUG=690296 Review-Url: https://codereview.chromium.org/2690563002 Cr-Commit-Position: refs/heads/master@{#449936} Committed: https://chromium.googlesource.com/chromium/src/+/7218269c5a015a91630aa94b1e3d696237a29d52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -13 lines) Patch
M components/policy/BUILD.gn View 3 chunks +29 lines, -3 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ramin Halavati
Dear Julian, The cloud policy proto generator script is modified so that full runtime proto ...
3 years, 10 months ago (2017-02-10 14:09:16 UTC) #2
pastarmovj
lgtm
3 years, 10 months ago (2017-02-13 11:19:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690563002/1
3 years, 10 months ago (2017-02-13 11:48:14 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:48:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7218269c5a015a91630aa94b1e3d...

Powered by Google App Engine
This is Rietveld 408576698