Cloud policy for full runtime added.

Cloud policy for full runtime added.

Cloud policy protobuf was generated only for LITE_RUNTIME optimized usage. An extra output is added that does not have this optimization option and hence can be imported in protobufs with full runtime features.

BUG=683131
Review-Url: https://codereview.chromium.org/2645053003
Cr-Commit-Position: refs/heads/master@{#445682}
Committed: https://chromium.googlesource.com/chromium/src/+/e22760de2837e4a82b606fee9de47bcfc8adff8e

[Ramin Halavati, 2017-01-20 13:41:37]

rhalavati@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[Ramin Halavati, 2017-01-20 13:41:38]

Hi,

I've added an extra cloud policy protobuf output that does not have LITE_RUNTIME
flag. Please review.

Bests,
Ramin

[pastarmovj, 2017-01-20 15:21:00]

On 2017/01/20 13:41:38, Ramin Halavati wrote:
> Hi,
> 
> I've added an extra cloud policy protobuf output that does not have
LITE_RUNTIME
> flag. Please review.
> 
> Bests,
> Ramin

Hi,
can you please provide some context why is this needed? The linked bug doesn't
provide much more in terms of who needs this output.
-Julian

[chromium-reviews, 2017-01-20 15:37:31]

Hi,

Sorry, this is <https://codereview.chromium.org/2421333002/>my main change
list, in which I want to import cloud privacy protobuf in network traffic
annotation protobuf.
Both protobufs in my code are serialized from human readable text and to do
that, protobufs cannot be optimized for lite runtime.
Please tell me if more background is required.

Bests,
Ramin

On Fri, Jan 20, 2017 at 4:20 PM, <pastarmovj@chromium.org> wrote:

> On 2017/01/20 13:41:38, Ramin Halavati wrote:
> > Hi,
> >
> > I've added an extra cloud policy protobuf output that does not have
> LITE_RUNTIME
> > flag. Please review.
> >
> > Bests,
> > Ramin
>
> Hi,
> can you please provide some context why is this needed? The linked bug
> doesn't
> provide much more in terms of who needs this output.
> -Julian
>
> https://codereview.chromium.org/2645053003/
>

Ramin Halavati

Software Engineer

rhalavati@google.com
+49 89 839300892

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.


This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ramin Halavati, 2017-01-20 15:38:12]

On 2017/01/20 15:21:00, pastarmovj wrote:
> On 2017/01/20 13:41:38, Ramin Halavati wrote:
> > Hi,
> > 
> > I've added an extra cloud policy protobuf output that does not have
> LITE_RUNTIME
> > flag. Please review.
> > 
> > Bests,
> > Ramin
> 
> Hi,
> can you please provide some context why is this needed? The linked bug doesn't
> provide much more in terms of who needs this output.
> -Julian

This is my main change list (https://codereview.chromium.org/2421333002/) , in
which I want to import cloud privacy protobuf in network traffic annotation
protobuf.
Both protobufs in my code are serialized from human readable text and to do
that, protobufs cannot be optimized for lite runtime.
Please tell me if more background is required.

[chromium-reviews, 2017-01-22 18:38:59]

Hi Ramin,

thanks for the reply. I see this is part of the awesome effort to annotate
the network requests. One more question I got is why would you need to
parse precisely those protos? I know they are also used inside requests but
do you need to parse the internals of these protos. I don't object the CL
just trying to potentially reduce complexity if this is something that
might not be needed in fact. :)

Best,
Julian

On Fri, Jan 20, 2017 at 7:36 AM, Ramin Halavati <rhalavati@google.com>
wrote:

> Hi,
>
> Sorry, this is <https://codereview.chromium.org/2421333002/>my main
> change list, in which I want to import cloud privacy protobuf in network
> traffic annotation protobuf.
> Both protobufs in my code are serialized from human readable text and to
> do that, protobufs cannot be optimized for lite runtime.
> Please tell me if more background is required.
>
> Bests,
> Ramin
>
>
> On Fri, Jan 20, 2017 at 4:20 PM, <pastarmovj@chromium.org> wrote:
>
>> On 2017/01/20 13:41:38, Ramin Halavati wrote:
>> > Hi,
>> >
>> > I've added an extra cloud policy protobuf output that does not have
>> LITE_RUNTIME
>> > flag. Please review.
>> >
>> > Bests,
>> > Ramin
>>
>> Hi,
>> can you please provide some context why is this needed? The linked bug
>> doesn't
>> provide much more in terms of who needs this output.
>> -Julian
>>
>> https://codereview.chromium.org/2645053003/
>>
>
> Ramin Halavati
>
> Software Engineer
>
> rhalavati@google.com
> +49 89 839300892 <089%20839300892>
>
> Google Germany GmbH
>
> Erika-Mann-Straße 33
>
> 80636 München
>
> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
>
> Registergericht und -nummer: Hamburg, HRB 86891
>
> Sitz der Gesellschaft: Hamburg
>
> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
> dass die E-Mail an die falsche Person gesendet wurde.
>
>
> This e-mail is confidential. If you received this communication by
> mistake, please don't forward it to anyone else, please erase all copies
> and attachments, and please let me know that it has gone to the wrong
> person.
>

Google Germany GmbH
Erika-Mann-Str. 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ramin Halavati, 2017-01-23 06:37:44]

Hi Julian,

Thank you very much. Our plan is to let developers write the annotations as
human readable text in proto serialized format (as seen in this sample:
https://codereview.chromium.org/2421333002/diff/160001/components/spellcheck/...),
then we extract the text using clang tools and convert it to protos and other
required data for next steps of reporting and auditing. Therefore, as our
proto's text is manually entered, we need it to be human readable and parsable.
Do you see any alternatives? It is still not in use and we are quite open to
changes.

About the modifications in your python file, if you prefer I can replace it with
another one in which I just remove the optimization line from the big text
describing proto when I write the full version.

Bests,
Ramin

On 2017/01/22 18:38:59, chromium-reviews wrote:
> Hi Ramin,
> 
> thanks for the reply. I see this is part of the awesome effort to annotate
> the network requests. One more question I got is why would you need to
> parse precisely those protos? I know they are also used inside requests but
> do you need to parse the internals of these protos. I don't object the CL
> just trying to potentially reduce complexity if this is something that
> might not be needed in fact. :)
> 
> Best,
> Julian
> 
> On Fri, Jan 20, 2017 at 7:36 AM, Ramin Halavati <mailto:rhalavati@google.com>
> wrote:
> 
> > Hi,
> >
> > Sorry, this is <https://codereview.chromium.org/2421333002/%3Emy main
> > change list, in which I want to import cloud privacy protobuf in network
> > traffic annotation protobuf.
> > Both protobufs in my code are serialized from human readable text and to
> > do that, protobufs cannot be optimized for lite runtime.
> > Please tell me if more background is required.
> >
> > Bests,
> > Ramin
> >
> >
> > On Fri, Jan 20, 2017 at 4:20 PM, <mailto:pastarmovj@chromium.org> wrote:
> >
> >> On 2017/01/20 13:41:38, Ramin Halavati wrote:
> >> > Hi,
> >> >
> >> > I've added an extra cloud policy protobuf output that does not have
> >> LITE_RUNTIME
> >> > flag. Please review.
> >> >
> >> > Bests,
> >> > Ramin
> >>
> >> Hi,
> >> can you please provide some context why is this needed? The linked bug
> >> doesn't
> >> provide much more in terms of who needs this output.
> >> -Julian
> >>
> >> https://codereview.chromium.org/2645053003/
> >>
> >
> > Ramin Halavati
> >
> > Software Engineer
> >
> > mailto:rhalavati@google.com
> > +49 89 839300892 <089%20839300892>
> >
> > Google Germany GmbH
> >
> > Erika-Mann-Straße 33
> >
> > 80636 München
> >
> > Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
> >
> > Registergericht und -nummer: Hamburg, HRB 86891
> >
> > Sitz der Gesellschaft: Hamburg
> >
> > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
> > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
> > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
> > dass die E-Mail an die falsche Person gesendet wurde.
> >
> >
> > This e-mail is confidential. If you received this communication by
> > mistake, please don't forward it to anyone else, please erase all copies
> > and attachments, and please let me know that it has gone to the wrong
> > person.
> >
> 
> Google Germany GmbH
> Erika-Mann-Str. 33
> 80636 München
> 
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[pastarmovj, 2017-01-23 16:54:14]

lgtm

[Ramin Halavati, 2017-01-24 06:51:55]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-01-24 06:52:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 08:38:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485240715796090, "parent_rev":
"7469f74a88dea8965e646230fc716d4dcd0c0e4e", "commit_rev":
"e22760de2837e4a82b606fee9de47bcfc8adff8e"}

[commit-bot: I haz the power, 2017-01-24 08:38:33]

Description was changed from

==========
Cloud policy for full runtime added.

Cloud policy protobuf was generated only for LITE_RUNTIME optimized usage. An
extra output is added that does not have this optimization option and hence can
be imported in protobufs with full runtime features.

BUG=683131
==========

to

==========
Cloud policy for full runtime added.

Cloud policy protobuf was generated only for LITE_RUNTIME optimized usage. An
extra output is added that does not have this optimization option and hence can
be imported in protobufs with full runtime features.

BUG=683131

Review-Url: https://codereview.chromium.org/2645053003
Cr-Commit-Position: refs/heads/master@{#445682}
Committed:
https://chromium.googlesource.com/chromium/src/+/e22760de2837e4a82b606fee9de4...
==========

[commit-bot: I haz the power, 2017-01-24 08:38:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e22760de2837e4a82b606fee9de4...