Add UMA for recording embargo reasons and autoblocker interactions.

Add UMA for recording embargo reasons and autoblocker interactions.

PermissionContextBase will now record interactions with
PermissionDecisionAutoBlocker, in particular those that lead to
embargoing of permission requests. Permission requests will fall into
one of the following buckets: embargo due to blacklisting, embargo due
to dismissals, or no embargo. The purpose of this UMA is to record when
and for what reason requests are placed under embargo. A follow up CL
will provide UMA for recording how often permission prompts aren't shown
due to existing embargo, and another will cover repeated embargo.

BUG=679877
Patch from http://crrev.com/2684913002#ps140001

Review-Url: https://codereview.chromium.org/2690543004
Cr-Commit-Position: refs/heads/master@{#450239}
Committed: https://chromium.googlesource.com/chromium/src/+/79b96cce371bead70ed2dccf7977e5f1fd09c6a0

[dominickn, 2017-02-10 09:47:16]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 09:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:47:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dominickn, 2017-02-12 23:47:52]

dominickn@chromium.org changed reviewers:
+ kcarattini@chromium.org, raymes@chromium.org, rkaplow@chromium.org

[dominickn, 2017-02-12 23:47:52]

PTAL, thanks. This is the same as https://codereview.chromium.org/2684913002/,
except rebased properly. meredithl@ has finished her internship so I am taking
this over.

[raymes, 2017-02-13 05:00:58]

Thanks Dom

https://codereview.chromium.org/2690543004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2690543004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_queue_controller.cc:247:
->RecordDismissAndEmbargo(requesting_frame, permission_type_)) {
Adding some Java tests sounds good to me :) Can we create a bug for that (which
can launch block the dismissals release)?

https://codereview.chromium.org/2690543004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2690543004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:46048: -<histogram
name="Permissions.AutoBlocker.SafeBrowsingResponse"
Let's fix the bad merge :)

[dominickn, 2017-02-13 05:24:37]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-02-13 05:24:47]

Thanks!

https://codereview.chromium.org/2690543004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2690543004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_queue_controller.cc:247:
->RecordDismissAndEmbargo(requesting_frame, permission_type_)) {
On 2017/02/13 05:00:58, raymes wrote:
> Adding some Java tests sounds good to me :) Can we create a bug for that
(which
> can launch block the dismissals release)?

Filed crbug.com/691437

https://codereview.chromium.org/2690543004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2690543004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:46048: -<histogram
name="Permissions.AutoBlocker.SafeBrowsingResponse"
On 2017/02/13 05:00:58, raymes wrote:
> Let's fix the bad merge :)

Done.

[kcarattini, 2017-02-13 05:24:53]

lgtm

Oops! Once more on the right cl:

lgtm once the merge issue is fixed.

Kendra

[commit-bot: I haz the power, 2017-02-13 05:24:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[raymes, 2017-02-13 05:57:10]

lgtm

[commit-bot: I haz the power, 2017-02-13 06:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 06:20:56]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-13 18:16:22]

lgtm

https://codereview.chromium.org/2690543004/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2690543004/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base.cc:324: }
this looks like this might be simpler if you just keep a status = 
PermissionEmbargoStatus::NOT_EMBARGOED inside each of these statements

and then a 
PermissionUmaUtil::RecordPermissionEmbargoStatus(status)

at the end, so it's clear there's a single emission

[dominickn, 2017-02-14 01:54:58]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-02-14 01:55:08]

Thanks!

https://codereview.chromium.org/2690543004/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2690543004/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_context_base.cc:324: }
On 2017/02/13 18:16:21, rkaplow wrote:
> this looks like this might be simpler if you just keep a status = 
> PermissionEmbargoStatus::NOT_EMBARGOED inside each of these statements
> 
> and then a 
> PermissionUmaUtil::RecordPermissionEmbargoStatus(status)
> 
> at the end, so it's clear there's a single emission

Done, thanks

[commit-bot: I haz the power, 2017-02-14 01:55:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 03:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:48:23]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-02-14 04:05:32]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-02-14 04:05:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
kcarattini@chromium.org, raymes@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2690543004/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2017-02-14 04:06:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:14:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487045132333720,
"parent_rev": "dfb72e700f9603d638fb9510d9c2f015c26cb8e8", "commit_rev":
"79b96cce371bead70ed2dccf7977e5f1fd09c6a0"}

[commit-bot: I haz the power, 2017-02-14 04:15:33]

Description was changed from

==========
Add UMA for recording embargo reasons and autoblocker interactions.

PermissionContextBase will now record interactions with
PermissionDecisionAutoBlocker, in particular those that lead to
embargoing of permission requests. Permission requests will fall into
one of the following buckets: embargo due to blacklisting, embargo due
to dismissals, or no embargo. The purpose of this UMA is to record when
and for what reason requests are placed under embargo. A follow up CL
will provide UMA for recording how often permission prompts aren't shown
due to existing embargo, and another will cover repeated embargo.

BUG=679877

Patch from http://crrev.com/2684913002#ps140001
==========

to

==========
Add UMA for recording embargo reasons and autoblocker interactions.

PermissionContextBase will now record interactions with
PermissionDecisionAutoBlocker, in particular those that lead to
embargoing of permission requests. Permission requests will fall into
one of the following buckets: embargo due to blacklisting, embargo due
to dismissals, or no embargo. The purpose of this UMA is to record when
and for what reason requests are placed under embargo. A follow up CL
will provide UMA for recording how often permission prompts aren't shown
due to existing embargo, and another will cover repeated embargo.

BUG=679877

Patch from http://crrev.com/2684913002#ps140001

Review-Url: https://codereview.chromium.org/2690543004
Cr-Commit-Position: refs/heads/master@{#450239}
Committed:
https://chromium.googlesource.com/chromium/src/+/79b96cce371bead70ed2dccf7977...
==========

[commit-bot: I haz the power, 2017-02-14 04:15:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/79b96cce371bead70ed2dccf7977...