Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5508)

Unified Diff: chrome/browser/permissions/permission_decision_auto_blocker.cc

Issue 2690543004: Add UMA for recording embargo reasons and autoblocker interactions. (Closed)
Patch Set: Address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_decision_auto_blocker.cc
diff --git a/chrome/browser/permissions/permission_decision_auto_blocker.cc b/chrome/browser/permissions/permission_decision_auto_blocker.cc
index 9bf499faad2b6b92ba052770636442bf8a1b54fd..f8ab89c4ca566987f47f46b2bca75552a48fa3ef 100644
--- a/chrome/browser/permissions/permission_decision_auto_blocker.cc
+++ b/chrome/browser/permissions/permission_decision_auto_blocker.cc
@@ -271,11 +271,7 @@ void PermissionDecisionAutoBlocker::UpdateEmbargoedStatus(
const GURL& request_origin,
content::WebContents* web_contents,
base::Callback<void(bool)> callback) {
- // Check if origin is currently under embargo for the requested permission.
- if (IsUnderEmbargo(permission, request_origin)) {
- callback.Run(true /* permission_blocked */);
- return;
- }
+ DCHECK(!IsUnderEmbargo(permission, request_origin));
if (base::FeatureList::IsEnabled(features::kPermissionsBlacklist) &&
db_manager_) {

Powered by Google App Engine
This is Rietveld 408576698