Refactor DelayedTaskManager to be Agnostic to Task Sources

Refactor DelayedTaskManager to be Agnostic to Task Sources

The upcoming work for one dedicated thread per SingleTaskTaskRunner
needs the services from the DelayedTaskManager to process tasks.

This change makes DelayedTaskManager agnostic to the task source
while allowing for a central place to set policy on delayed tasks
especially in the face of different task sources.

Reference Change:
https://codereview.chromium.org/2686593003/

BUG=684080
Review-Url: https://codereview.chromium.org/2690483002
Cr-Commit-Position: refs/heads/master@{#449707}
Committed: https://chromium.googlesource.com/chromium/src/+/f77c24b4773e3c145e68cd923c6ec673e47cb8cd

[robliao, 2017-02-10 02:13:51]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2017-02-10 02:14:09]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:14:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 08:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:15:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-02-10 13:04:07]

LGTM

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
File base/task_scheduler/delayed_task_manager.cc (right):

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
base/task_scheduler/delayed_task_manager.cc:12: #include
"base/task_scheduler/scheduler_worker_pool.h"
Remove this include.

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
File base/task_scheduler/delayed_task_manager.h (right):

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
base/task_scheduler/delayed_task_manager.h:14: #include "base/time/time.h"
Remove this include.

[robliao, 2017-02-10 18:13:35]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2017-02-10 18:13:57]

Done. Thanks!

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
File base/task_scheduler/delayed_task_manager.cc (right):

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
base/task_scheduler/delayed_task_manager.cc:12: #include
"base/task_scheduler/scheduler_worker_pool.h"
On 2017/02/10 13:04:06, fdoray wrote:
> Remove this include.

Done.

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
File base/task_scheduler/delayed_task_manager.h (right):

https://codereview.chromium.org/2690483002/diff/1/base/task_scheduler/delayed...
base/task_scheduler/delayed_task_manager.h:14: #include "base/time/time.h"
On 2017/02/10 13:04:06, fdoray wrote:
> Remove this include.

Done.

[commit-bot: I haz the power, 2017-02-10 18:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 18:22:36]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[robliao, 2017-02-10 18:23:37]

Patchset #2 (id:20001) has been deleted

[robliao, 2017-02-10 18:23:55]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 18:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:40:21]

Dry run: This issue passed the CQ dry run.

[robliao, 2017-02-10 19:40:37]

The CQ bit was checked by robliao@chromium.org

[robliao, 2017-02-10 19:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org
Link to the patchset: https://codereview.chromium.org/2690483002/#ps40001
(title: "Update Includes")

[commit-bot: I haz the power, 2017-02-10 19:41:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:56:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486755637669250,
"parent_rev": "82f31c2e73e855f3f8b4aacc29d00bfe4c7973ba", "commit_rev":
"f77c24b4773e3c145e68cd923c6ec673e47cb8cd"}

[commit-bot: I haz the power, 2017-02-10 19:56:41]

Description was changed from

==========
Refactor DelayedTaskManager to be Agnostic to Task Sources

The upcoming work for one dedicated thread per SingleTaskTaskRunner
needs the services from the DelayedTaskManager to process tasks.

This change makes DelayedTaskManager agnostic to the task source
while allowing for a central place to set policy on delayed tasks
especially in the face of different task sources.

Reference Change:
https://codereview.chromium.org/2686593003/

BUG=684080
==========

to

==========
Refactor DelayedTaskManager to be Agnostic to Task Sources

The upcoming work for one dedicated thread per SingleTaskTaskRunner
needs the services from the DelayedTaskManager to process tasks.

This change makes DelayedTaskManager agnostic to the task source
while allowing for a central place to set policy on delayed tasks
especially in the face of different task sources.

Reference Change:
https://codereview.chromium.org/2686593003/

BUG=684080

Review-Url: https://codereview.chromium.org/2690483002
Cr-Commit-Position: refs/heads/master@{#449707}
Committed:
https://chromium.googlesource.com/chromium/src/+/f77c24b4773e3c145e68cd923c6e...
==========

[commit-bot: I haz the power, 2017-02-10 19:56:42]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f77c24b4773e3c145e68cd923c6e...

[gab, 2017-02-10 20:02:53]

lgtm