Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2907)

Unified Diff: base/task_scheduler/delayed_task_manager.cc

Issue 2690483002: Refactor DelayedTaskManager to be Agnostic to Task Sources (Closed)
Patch Set: Update Includes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/delayed_task_manager.h ('k') | base/task_scheduler/delayed_task_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/delayed_task_manager.cc
diff --git a/base/task_scheduler/delayed_task_manager.cc b/base/task_scheduler/delayed_task_manager.cc
index 1cc928b0f0d080d926813c97037e2a68da7710b7..1921364bd1e6154f644c06d0ed1a3b26af57e6ad 100644
--- a/base/task_scheduler/delayed_task_manager.cc
+++ b/base/task_scheduler/delayed_task_manager.cc
@@ -9,7 +9,7 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/task_runner.h"
-#include "base/task_scheduler/scheduler_worker_pool.h"
+#include "base/task_scheduler/task.h"
namespace base {
namespace internal {
@@ -22,13 +22,10 @@ DelayedTaskManager::DelayedTaskManager(
DelayedTaskManager::~DelayedTaskManager() = default;
-void DelayedTaskManager::AddDelayedTask(std::unique_ptr<Task> task,
- scoped_refptr<Sequence> sequence,
- SchedulerWorker* worker,
- SchedulerWorkerPool* worker_pool) {
+void DelayedTaskManager::AddDelayedTask(
+ std::unique_ptr<Task> task,
+ const PostTaskNowCallback& post_task_now_callback) {
DCHECK(task);
- DCHECK(sequence);
- DCHECK(worker_pool);
const TimeDelta delay = task->delay;
DCHECK(!delay.is_zero());
@@ -36,10 +33,7 @@ void DelayedTaskManager::AddDelayedTask(std::unique_ptr<Task> task,
// TODO(fdoray): Use |task->delayed_run_time| on the service thread
// MessageLoop rather than recomputing it from |delay|.
service_thread_task_runner_->PostDelayedTask(
- FROM_HERE, Bind(&SchedulerWorkerPool::PostTaskWithSequenceNow,
- Unretained(worker_pool), Passed(std::move(task)),
- std::move(sequence), Unretained(worker)),
- delay);
+ FROM_HERE, Bind(post_task_now_callback, Passed(std::move(task))), delay);
}
} // namespace internal
« no previous file with comments | « base/task_scheduler/delayed_task_manager.h ('k') | base/task_scheduler/delayed_task_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698