Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2690363002: chromeos: removes mash shadows (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: removes mash shadows We're actually using the ash ones already. BUG=670840 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2690363002 Cr-Commit-Position: refs/heads/master@{#450485} Committed: https://chromium.googlesource.com/chromium/src/+/5c328211dc652bed2edc3fb24858079b0e632ed5

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -523 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 1 2 chunks +0 lines, -20 lines 0 comments Download
D ash/mus/shadow.h View 1 chunk +0 lines, -113 lines 0 comments Download
D ash/mus/shadow.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D ash/mus/shadow_controller.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ash/mus/shadow_controller.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M ash/mus/window_manager.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M ash/mus/window_manager.cc View 1 2 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
3 years, 10 months ago (2017-02-14 01:02:59 UTC) #1
James Cook
LGTM! I love +0/-500 line patches.
3 years, 10 months ago (2017-02-14 02:06:54 UTC) #2
sky
On 2017/02/14 02:06:54, James Cook wrote: > LGTM! I love +0/-500 line patches. To be ...
3 years, 10 months ago (2017-02-14 17:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690363002/40001
3 years, 10 months ago (2017-02-14 20:39:12 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:06:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c328211dc652bed2edc3fb24858...

Powered by Google App Engine
This is Rietveld 408576698