Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2690303011: Revert of NQE: Record the main frame metrics at transaction start (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NQE: Record the main frame metrics at transaction start (patchset #2 id:60001 of https://codereview.chromium.org/2695783003/ ) Reason for revert: Caused perf regression. See https://bugs.chromium.org/p/chromium/issues/detail?id=692933 Original issue's description: > NQE: Record the main frame metrics at transaction start > > In network quality estimator (NQE), record the main frame metrics at the > beginning of transaction start, instead of when the response headers have > been received for the main frame. > > BUG=691798 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2695783003 > Cr-Commit-Position: refs/heads/master@{#450536} > Committed: https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb1144abdd2469c2 TBR=ryansturm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=691798, 692933 Review-Url: https://codereview.chromium.org/2690303011 Cr-Commit-Position: refs/heads/master@{#451106} Committed: https://chromium.googlesource.com/chromium/src/+/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -55 lines) Patch
M net/nqe/network_quality_estimator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 3 chunks +18 lines, -23 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 10 chunks +24 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
tbansal1
Created Revert of NQE: Record the main frame metrics at transaction start
3 years, 10 months ago (2017-02-16 19:51:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690303011/1
3 years, 10 months ago (2017-02-16 19:52:43 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 21:45:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c82d9e4024d4ada2d0a0677c2ced...

Powered by Google App Engine
This is Rietveld 408576698