Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5104)

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 2690303003: MD Settings: Disable tests for ASAN bots. (Closed)
Patch Set: Fix ChromeOS. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/cr_settings_browsertest.js
diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js
index 5ae0041edc5210bda6c2c0a8adae0dbee0003c7b..8c43a2bbaa85154361af7d37aafb15adc364a8fb 100644
--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js
+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js
@@ -980,13 +980,6 @@ TEST_F('CrSettingsNonExistentRouteTest', 'All', function() {
mocha.run();
});
-// Hangs on ASAN builder for unknown reasons. TODO(michaelpg): Find reason.
-GEN('#if defined(ADDRESS_SANITIZER)');
-GEN('#define MAYBE_All DISABLED_All');
-GEN('#else');
-GEN('#define MAYBE_All All');
-GEN('#endif');
-
/**
* @constructor
* @extends {SettingsPageBrowserTest}
@@ -1003,7 +996,7 @@ CrSettingsRouteDynamicParametersTest.prototype = {
runAccessibilityChecks: false,
};
-TEST_F('CrSettingsRouteDynamicParametersTest', 'MAYBE_All', function() {
+TEST_F('CrSettingsRouteDynamicParametersTest', 'All', function() {
suite('DynamicParameters', function() {
test('get parameters from URL and navigation', function(done) {
assertEquals(settings.Route.PEOPLE, settings.getCurrentRoute());
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698