RELAND: Shape detection unittests mac (QR and Face) in GPU bots

RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org, bsalomon@chromium.org, erg@chromium.org 
since the changes are straightforward and only affect tests.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed: https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b3a50f8d43865

patch from issue 2677553003 at patchset 280001 (http://crrev.com/2677553003#ps280001)

Review-Url: https://codereview.chromium.org/2690253002
Cr-Commit-Position: refs/heads/master@{#450213}
Committed: https://chromium.googlesource.com/chromium/src/+/7f59d2c0512aae8b641dab53f6a44c407c5f8086

[mcasas, 2017-02-13 22:45:43]

Description was changed from

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots




Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)
==========

to

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)
==========

[mcasas, 2017-02-13 23:22:45]

Description was changed from

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)
==========

to

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org,
bsalomon@chromium.org, erg@chromium.org 
since the changes are straightforward and only affect tests.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)
==========

[mcasas, 2017-02-13 23:24:31]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 23:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:48:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2017-02-14 00:05:37]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-02-14 00:06:06]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-14 00:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-02-14 01:01:57]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-02-14 01:01:58]

lgtm

https://codereview.chromium.org/2690253002/diff/40001/services/shape_detectio...
File services/shape_detection/PRESUBMIT.py (right):

https://codereview.chromium.org/2690253002/diff/40001/services/shape_detectio...
services/shape_detection/PRESUBMIT.py:17: the Mac GPU bots in addition to the
usual CQ try bots.
FYI, I'm fixing up these presubmit scripts in http://crbug.com/688765 . I'll fix
up this one after you land it.

[mcasas, 2017-02-14 01:03:30]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-02-14 01:03:36]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:04:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 02:50:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487034216256180,
"parent_rev": "2404c8ae0098fa7cae48db92222240293a9d2689", "commit_rev":
"7f59d2c0512aae8b641dab53f6a44c407c5f8086"}

[commit-bot: I haz the power, 2017-02-14 02:51:32]

Description was changed from

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org,
bsalomon@chromium.org, erg@chromium.org 
since the changes are straightforward and only affect tests.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)
==========

to

==========
RELAND: Shape detection unittests mac (QR and Face) in GPU bots

The original CL got reverted due to failing in the Mac10.10Tests bot,
which was not adequately filtered out because it wasn't in the CQ :-)

This reland uses --use-gpu-in-tests like all other GPU-specific
tests, checking its presence in the added files.

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org,
bsalomon@chromium.org, erg@chromium.org 
since the changes are straightforward and only affect tests.

Original CL description ------------------------------------------------
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of
service_unittests.  These new tests are run in the gpu bots, bc
the normal Mac bots don't have GPUs and that seems to screw
the CoreImage library (FTR I tried loading the lib and symbols in
runtime and/or using a software rendering context, see PS2, but
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

patch from issue 2677553003 at patchset 280001
(http://crrev.com/2677553003#ps280001)

Review-Url: https://codereview.chromium.org/2690253002
Cr-Commit-Position: refs/heads/master@{#450213}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f59d2c0512aae8b641dab53f6a4...
==========

[commit-bot: I haz the power, 2017-02-14 02:51:37]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7f59d2c0512aae8b641dab53f6a4...