Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2690143005: Make comment about symbol_level=2 explicit that it slows compile (Closed)

Created:
3 years, 10 months ago by danakj
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, dpranke, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make comment about symbol_level=2 explicit that it slows compile As seen in this thread, symbol_level=2 doesn't make a big runtime change but is avoided to make the build faster. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/AZZ04wssLoY/discussion R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2690143005 Cr-Commit-Position: refs/heads/master@{#450604} Committed: https://chromium.googlesource.com/chromium/src/+/f167e0d77f11f8f1770607d39bd9205dfd1403bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/config/compiler/compiler.gni View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
danakj
3 years, 10 months ago (2017-02-15 00:20:30 UTC) #4
Nico
lgtm
3 years, 10 months ago (2017-02-15 00:28:00 UTC) #5
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-15 00:35:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690143005/1
3 years, 10 months ago (2017-02-15 00:42:51 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 06:45:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f167e0d77f11f8f1770607d39bd9...

Powered by Google App Engine
This is Rietveld 408576698