Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2690143005: Make comment about symbol_level=2 explicit that it slows compile (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/pgo/pgo.gni") 8 import("//build/config/compiler/pgo/pgo.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/toolchain/goma.gni") 10 import("//build/toolchain/goma.gni")
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 symbol_level = 1 94 symbol_level = 1
95 } else if (is_win && use_goma && !is_clang) { 95 } else if (is_win && use_goma && !is_clang) {
96 # goma doesn't support PDB files, so we disable symbols during goma 96 # goma doesn't support PDB files, so we disable symbols during goma
97 # compilation because otherwise the redundant debug information generated 97 # compilation because otherwise the redundant debug information generated
98 # by visual studio (repeated in every .obj file) makes linker 98 # by visual studio (repeated in every .obj file) makes linker
99 # memory consumption and link times unsustainable (crbug.com/630074). 99 # memory consumption and link times unsustainable (crbug.com/630074).
100 # Clang on windows does not have this issue. 100 # Clang on windows does not have this issue.
101 symbol_level = 1 101 symbol_level = 1
102 } else if ((!is_nacl && !is_linux) || is_debug || is_official_build || 102 } else if ((!is_nacl && !is_linux) || is_debug || is_official_build ||
103 is_chromecast) { 103 is_chromecast) {
104 # Linux is slowed by having symbols as part of the target binary, whereas 104 # Linux builds slower by having symbols as part of the target binary,
105 # Mac and Windows have them separate, so in Release Linux, default them off, 105 # whereas Mac and Windows have them separate, so in Release Linux, default
106 # but keep them on for Official builds and Chromecast builds. 106 # them off, but keep them on for Official builds and Chromecast builds.
107 symbol_level = 2 107 symbol_level = 2
108 } else if (using_sanitizer) { 108 } else if (using_sanitizer) {
109 # Sanitizers require symbols for filename suppressions to work. 109 # Sanitizers require symbols for filename suppressions to work.
110 symbol_level = 1 110 symbol_level = 1
111 } else { 111 } else {
112 symbol_level = 0 112 symbol_level = 0
113 } 113 }
114 } 114 }
115 115
116 # Assert that the configuration isn't going to hit https://crbug.com/648948. 116 # Assert that the configuration isn't going to hit https://crbug.com/648948.
117 assert(ignore_elf32_limitations || !is_android || 117 assert(ignore_elf32_limitations || !is_android ||
118 (android_64bit_target_cpu && !build_apk_secondary_abi) || 118 (android_64bit_target_cpu && !build_apk_secondary_abi) ||
119 is_component_build || symbol_level < 2, 119 is_component_build || symbol_level < 2,
120 "Android 32-bit non-component, non-clang builds cannot have " + 120 "Android 32-bit non-component, non-clang builds cannot have " +
121 "symbol_level=2 due to 4GiB file size limit, see " + 121 "symbol_level=2 due to 4GiB file size limit, see " +
122 "https://crbug.com/648948. If you really want to try this out, " + 122 "https://crbug.com/648948. If you really want to try this out, " +
123 "set ignore_elf32_limitations=true.") 123 "set ignore_elf32_limitations=true.")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698