Abstract OSMesa from the Layout tests

Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
GL", which can apply to OSMesa or SwiftShader. The new function,
GetSoftwareGLImplementation(), which currently always returns
kGLImplementationOSMesaGL in order to preserve the current behavior,
will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2690113010
Cr-Commit-Position: refs/heads/master@{#450946}
Committed: https://chromium.googlesource.com/chromium/src/+/6fdc0748d97e254124025dac675676ac7e029fb4

[sugoi1, 2017-02-14 19:41:20]

Description was changed from

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
renderer", which can apply to OSMesa or SwiftShader. The new
function, GetSoftwareGLImplementation(), which currently always
returns kGLImplementationOSMesaGL in order to preserve the current
behavior, will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
==========

to

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
renderer", which can apply to OSMesa or SwiftShader. The new
function, GetSoftwareGLImplementation(), which currently always
returns kGLImplementationOSMesaGL in order to preserve the current
behavior, will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sugoi1, 2017-02-14 19:41:54]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 19:42:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi1, 2017-02-14 19:45:02]

sugoi@chromium.org changed reviewers:
+ jbauman@chromium.org, kbr@chromium.org

[sugoi1, 2017-02-14 19:45:02]

I will soon update SwiftShader's backend to use Subzero instead of LLVM. After
this cl lands, I'll be able to enable SwiftShader for Layout Tests on Windows by
modifying GetSoftwareGLImplementation() to something like:

#if defined(OS_WIN)
  return kGLImplementationSwiftShaderGL;
#else
  return kGLImplementationOSMesaGL;
#endif

[commit-bot: I haz the power, 2017-02-14 20:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:05:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sugoi1, 2017-02-14 21:05:02]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:11:34]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-02-15 00:43:48]

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
File content/public/test/browser_test_base.h (right):

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
content/public/test/browser_test_base.h:126: bool UsingSoftwareRenderer() const;
Maybe call this UsingSoftwareGL() instead. Otherwise it's easy to confuse this
with  UseSoftwareCompositing() above.

[Ken Russell (switch to Gerrit), 2017-02-15 02:32:15]

LGTM overall. Naming nits only.

https://codereview.chromium.org/2690113010/diff/20001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2690113010/diff/20001/content/browser/gpu/gpu...
content/browser/gpu/gpu_data_manager_impl_private.cc:539: const bool
force_software_rendering =
Could you rename this to force_software_gl?

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
File content/public/test/browser_test_base.cc (right):

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
content/public/test/browser_test_base.cc:239: bool use_software_renderer = true;
Let's call this use_software_gl.

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
File content/public/test/browser_test_base.h (right):

https://codereview.chromium.org/2690113010/diff/20001/content/public/test/bro...
content/public/test/browser_test_base.h:126: bool UsingSoftwareRenderer() const;
On 2017/02/15 00:43:48, jbauman wrote:
> Maybe call this UsingSoftwareGL() instead. Otherwise it's easy to confuse this
> with  UseSoftwareCompositing() above.

+1 to John's suggestion.

https://codereview.chromium.org/2690113010/diff/20001/ui/gl/init/gl_factory.cc
File ui/gl/init/gl_factory.cc (right):

https://codereview.chromium.org/2690113010/diff/20001/ui/gl/init/gl_factory.c...
ui/gl/init/gl_factory.cc:32: bool fallback_to_software_rendering = false;
Could you call this fallback_to_software_gl?

https://codereview.chromium.org/2690113010/diff/20001/ui/gl/test/gl_surface_t...
File ui/gl/test/gl_surface_test_support.cc (right):

https://codereview.chromium.org/2690113010/diff/20001/ui/gl/test/gl_surface_t...
ui/gl/test/gl_surface_test_support.cc:37: bool use_software_renderer = true;
Similar here.

[sugoi1, 2017-02-15 16:47:22]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 16:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi1, 2017-02-15 16:48:21]

Fixed naming nits

[commit-bot: I haz the power, 2017-02-15 17:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 17:56:59]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sugoi1, 2017-02-15 19:25:31]

sugoi@chromium.org changed reviewers:
+ mkwst@chromium.org, peter@chromium.org, sky@chromium.org

[sugoi1, 2017-02-15 19:25:32]

Adding sky@ for trivial changes in:
chrome/browser/extensions/api/tab_capture/
content/public/test/
mash/
services/ui/ws/
ui/views/mus/

Adding mkwst@ and peter@ for trivial changes in:
content/shell/app/

[sugoi1, 2017-02-15 19:54:24]

Description was changed from

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
renderer", which can apply to OSMesa or SwiftShader. The new
function, GetSoftwareGLImplementation(), which currently always
returns kGLImplementationOSMesaGL in order to preserve the current
behavior, will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
GL", which can apply to OSMesa or SwiftShader. The new function,
GetSoftwareGLImplementation(), which currently always returns
kGLImplementationOSMesaGL in order to preserve the current behavior,
will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sky, 2017-02-15 21:08:30]

LGTM

[Peter Beverloo, 2017-02-15 21:40:06]

lgtm

[sugoi1, 2017-02-15 21:52:16]

The CQ bit was checked by sugoi@chromium.org

[sugoi1, 2017-02-15 21:52:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2690113010/#ps40001
(title: "Renamed "Renderer" to "GL"")

[commit-bot: I haz the power, 2017-02-15 21:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:25:04]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sugoi, 2017-02-16 03:36:33]

The CQ bit was checked by sugoi@google.com

[commit-bot: I haz the power, 2017-02-16 03:37:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi, 2017-02-16 04:18:23]

The CQ bit was unchecked by sugoi@google.com

[sugoi, 2017-02-16 04:18:40]

The CQ bit was checked by sugoi@google.com

[commit-bot: I haz the power, 2017-02-16 04:19:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:40:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[sugoi1, 2017-02-16 13:36:03]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2017-02-16 13:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 13:42:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487252163656790,
"parent_rev": "600a1b10bce210bcd850268024a2413a0ee0d0fa", "commit_rev":
"6fdc0748d97e254124025dac675676ac7e029fb4"}

[commit-bot: I haz the power, 2017-02-16 13:42:41]

Description was changed from

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
GL", which can apply to OSMesa or SwiftShader. The new function,
GetSoftwareGLImplementation(), which currently always returns
kGLImplementationOSMesaGL in order to preserve the current behavior,
will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Abstract OSMesa from the Layout tests

In order to be able to switch between SwiftShader and OSMesa based
on the platform being used, OSMesa was abstracted to just "software
GL", which can apply to OSMesa or SwiftShader. The new function,
GetSoftwareGLImplementation(), which currently always returns
kGLImplementationOSMesaGL in order to preserve the current behavior,
will be used to switch between SwiftShader and OSMesa.

This current change should be a noop, it simply makes it easy to
switch between renderers.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2690113010
Cr-Commit-Position: refs/heads/master@{#450946}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fdc0748d97e254124025dac6756...
==========

[commit-bot: I haz the power, 2017-02-16 13:42:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6fdc0748d97e254124025dac6756...