[Reading List iOS] Collapse whitespace on item title.

[Reading List iOS] Collapse whitespace on item title.

When adding an entry or after distillation, set collapse whitespaces on
titles to remove new lines and consecutive spaces.

BUG=690845
Review-Url: https://codereview.chromium.org/2690003004
Cr-Commit-Position: refs/heads/master@{#450328}
Committed: https://chromium.googlesource.com/chromium/src/+/9e87351607a343f906b1866ea41767434986ebbe

[Olivier, 2017-02-13 17:21:06]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-02-14 08:37:26]

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
File components/reading_list/ios/reading_list_model_impl.cc (right):

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry
entry(url, trimmed_title);
What happens if the entry is added with empty title at the start?

[Olivier, 2017-02-14 08:44:47]

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
File components/reading_list/ios/reading_list_model_impl.cc (right):

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry
entry(url, trimmed_title);
On 2017/02/14 08:37:26, gambard wrote:
> What happens if the entry is added with empty title at the start?

tab.title is never empty, so it does not happen when adding an item from Reading
List.
If using the share extension, the line stays empty.
I propose to add a fix in ReadingListCollectionViewController to set title to
URL if there is no title.

[Olivier, 2017-02-14 09:09:53]

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
File components/reading_list/ios/reading_list_model_impl.cc (right):

https://codereview.chromium.org/2690003004/diff/20001/components/reading_list...
components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry
entry(url, trimmed_title);
On 2017/02/14 08:44:47, Olivier Robin wrote:
> On 2017/02/14 08:37:26, gambard wrote:
> > What happens if the entry is added with empty title at the start?
> 
> tab.title is never empty, so it does not happen when adding an item from
Reading
> List.
> If using the share extension, the line stays empty.
> I propose to add a fix in ReadingListCollectionViewController to set title to
> URL if there is no title.

Done.

[gambard, 2017-02-14 11:58:20]

lgtm

[Olivier, 2017-02-14 11:58:42]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:58:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 12:11:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487073522542370,
"parent_rev": "3d55dbf466a4a696920ceecff3f8ef83fa51b91b", "commit_rev":
"9e87351607a343f906b1866ea41767434986ebbe"}

[commit-bot: I haz the power, 2017-02-14 12:11:53]

Description was changed from

==========
[Reading List iOS] Collapse whitespace on item title.

When adding an entry or after distillation, set collapse whitespaces on
titles to remove new lines and consecutive spaces.

BUG=690845
==========

to

==========
[Reading List iOS] Collapse whitespace on item title.

When adding an entry or after distillation, set collapse whitespaces on
titles to remove new lines and consecutive spaces.

BUG=690845

Review-Url: https://codereview.chromium.org/2690003004
Cr-Commit-Position: refs/heads/master@{#450328}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e87351607a343f906b1866ea417...
==========

[commit-bot: I haz the power, 2017-02-14 12:11:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e87351607a343f906b1866ea417...