Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2690003004: [Reading List iOS] Collapse whitespace on item title. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List iOS] Collapse whitespace on item title. When adding an entry or after distillation, set collapse whitespaces on titles to remove new lines and consecutive spaces. BUG=690845 Review-Url: https://codereview.chromium.org/2690003004 Cr-Commit-Position: refs/heads/master@{#450328} Committed: https://chromium.googlesource.com/chromium/src/+/9e87351607a343f906b1866ea41767434986ebbe

Patch Set 1 #

Patch Set 2 : set title + case #

Total comments: 3

Patch Set 3 : use url as title #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M components/reading_list/ios/reading_list_model_impl.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M components/reading_list/ios/reading_list_model_unittest.mm View 1 1 chunk +14 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Olivier
3 years, 10 months ago (2017-02-13 17:21:07 UTC) #2
gambard
https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc File components/reading_list/ios/reading_list_model_impl.cc (right): https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc#newcode318 components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry entry(url, trimmed_title); What happens if the entry is ...
3 years, 10 months ago (2017-02-14 08:37:26 UTC) #3
Olivier
https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc File components/reading_list/ios/reading_list_model_impl.cc (right): https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc#newcode318 components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry entry(url, trimmed_title); On 2017/02/14 08:37:26, gambard wrote: > ...
3 years, 10 months ago (2017-02-14 08:44:47 UTC) #4
Olivier
https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc File components/reading_list/ios/reading_list_model_impl.cc (right): https://codereview.chromium.org/2690003004/diff/20001/components/reading_list/ios/reading_list_model_impl.cc#newcode318 components/reading_list/ios/reading_list_model_impl.cc:318: ReadingListEntry entry(url, trimmed_title); On 2017/02/14 08:44:47, Olivier Robin wrote: ...
3 years, 10 months ago (2017-02-14 09:09:53 UTC) #5
gambard
lgtm
3 years, 10 months ago (2017-02-14 11:58:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690003004/40001
3 years, 10 months ago (2017-02-14 11:58:58 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 12:11:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e87351607a343f906b1866ea417...

Powered by Google App Engine
This is Rietveld 408576698