Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Issue 2690003004: [Reading List iOS] Collapse whitespace on item title. (Closed)
Patch Set: use url as title Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_download_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
index c29af39efe29996cf98a3ef58aa1dbbf80122e4c..f8e245ac800c1ea36d2684b2e685542e8d3328ae 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
@@ -512,9 +512,10 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
attributesProvider:self.attributesProvider
url:url
distillationState:entry.DistilledState()];
- base::string16 urlString = url_formatter::FormatUrl(url);
- item.text = base::SysUTF8ToNSString(entry.Title());
- item.detailText = base::SysUTF16ToNSString(urlString);
+ NSString* urlString = base::SysUTF16ToNSString(url_formatter::FormatUrl(url));
+ NSString* title = base::SysUTF8ToNSString(entry.Title());
+ item.text = [title length] ? title : urlString;
+ item.detailText = urlString;
item.faviconPageURL =
entry.DistilledURL().is_valid() ? entry.DistilledURL() : url;
return item;
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_download_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698