Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2689983002: Revert of Change ComputedStyle::setUnique to take bool parameter. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change ComputedStyle::setUnique to take bool parameter. (patchset #1 id:1 of https://codereview.chromium.org/2677843002/ ) Reason for revert: After discussion, it makes more sense for setUnique to take no arguments. Original issue's description: > Change ComputedStyle::setUnique to take bool parameter. > > Currently setUnique() takes no arguments and sets the corresponding > nonproperty flag to be true. However, this is different to the > traditional setters of property fields, where they set the field to an > argument value. Instead of handling setUnique as a special case in the > generator, we change setUnique to a normal setter that takes a boolean > parameter. This decision was discussed in crrev.com/2667543002. > > This is prework for generating 'unique'. > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2677843002 > Cr-Commit-Position: refs/heads/master@{#448774} > Committed: https://chromium.googlesource.com/chromium/src/+/25b1de1a5da3dbe754e4461cdd5c7ca2b3502ab6 TBR=sashab@chromium.org,esprehn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628043 Review-Url: https://codereview.chromium.org/2689983002 Cr-Commit-Position: refs/heads/master@{#449918} Committed: https://chromium.googlesource.com/chromium/src/+/062539120d0c3585f8a0a393246c5b98e0cd26f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
shend
Created Revert of Change ComputedStyle::setUnique to take bool parameter.
3 years, 10 months ago (2017-02-13 02:36:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689983002/1
3 years, 10 months ago (2017-02-13 02:37:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-13 02:37:13 UTC) #5
shend
Hi Naina, PTAL
3 years, 10 months ago (2017-02-13 02:44:37 UTC) #7
nainar
On 2017/02/13 at 02:44:37, shend wrote: > Hi Naina, PTAL Doesn't qualify for revert since ...
3 years, 10 months ago (2017-02-13 02:47:46 UTC) #8
meade_UTC10
lgtm
3 years, 10 months ago (2017-02-13 06:25:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689983002/1
3 years, 10 months ago (2017-02-13 06:41:26 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 08:23:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/062539120d0c3585f8a0a393246c...

Powered by Google App Engine
This is Rietveld 408576698