Change ComputedStyle::setUnique to take bool parameter.

Change ComputedStyle::setUnique to take bool parameter.

Currently setUnique() takes no arguments and sets the corresponding
nonproperty flag to be true. However, this is different to the
traditional setters of property fields, where they set the field to an
argument value. Instead of handling setUnique as a special case in the
generator, we change setUnique to a normal setter that takes a boolean
parameter. This decision was discussed in crrev.com/2667543002.

This is prework for generating 'unique'.

BUG=628043
Review-Url: https://codereview.chromium.org/2677843002
Cr-Commit-Position: refs/heads/master@{#448774}
Committed: https://chromium.googlesource.com/chromium/src/+/25b1de1a5da3dbe754e4461cdd5c7ca2b3502ab6

[sashab, 2017-02-07 02:57:00]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-02-07 02:57:00]

lgtm

[shend, 2017-02-07 21:20:30]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:13:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486502430794210, "parent_rev":
"00f7089132148e96541a6a476a68809790048e81", "commit_rev":
"25b1de1a5da3dbe754e4461cdd5c7ca2b3502ab6"}

[commit-bot: I haz the power, 2017-02-07 23:14:42]

Description was changed from

==========
Change ComputedStyle::setUnique to take bool parameter.

Currently setUnique() takes no arguments and sets the corresponding
nonproperty flag to be true. However, this is different to the
traditional setters of property fields, where they set the field to an
argument value. Instead of handling setUnique as a special case in the
generator, we change setUnique to a normal setter that takes a boolean
parameter. This decision was discussed in crrev.com/2667543002.

This is prework for generating 'unique'.

BUG=628043
==========

to

==========
Change ComputedStyle::setUnique to take bool parameter.

Currently setUnique() takes no arguments and sets the corresponding
nonproperty flag to be true. However, this is different to the
traditional setters of property fields, where they set the field to an
argument value. Instead of handling setUnique as a special case in the
generator, we change setUnique to a normal setter that takes a boolean
parameter. This decision was discussed in crrev.com/2667543002.

This is prework for generating 'unique'.

BUG=628043

Review-Url: https://codereview.chromium.org/2677843002
Cr-Commit-Position: refs/heads/master@{#448774}
Committed:
https://chromium.googlesource.com/chromium/src/+/25b1de1a5da3dbe754e4461cdd5c...
==========

[commit-bot: I haz the power, 2017-02-07 23:14:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25b1de1a5da3dbe754e4461cdd5c...

[esprehn, 2017-02-08 00:05:18]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2017-02-08 00:05:19]

I'm not sure this is a good idea, doing setUnique(false) is always wrong. :/

[sashab, 2017-02-08 00:53:21]

How come? The default value is false, so calling setUnique(false) is resetting
it to the default value. Many callers check unique() and expect true or false.

[shend, 2017-02-11 22:04:49]

On 2017/02/08 at 00:53:21, sashab wrote:
> How come? The default value is false, so calling setUnique(false) is resetting
it to the default value. Many callers check unique() and expect true or false.

Are we going ahead with this? If we change setUnique, we'll have to change all
the other setters as well for consistency (setIsLink, setExplicitInheritance
etc.) I think we should keep it as setUnique(), and handle nonproperty setters
as a special case (which we will need to do anyway when we generate platform
types).

[shend, 2017-02-13 02:36:54]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2689983002/ by shend@chromium.org.

The reason for reverting is: After discussion, it makes more sense for setUnique
to take no arguments..

[esprehn, 2017-02-13 23:50:24]

On 2017/02/08 at 00:53:21, sashab wrote:
> How come? The default value is false, so calling setUnique(false) is resetting
it to the default value. Many callers check unique() and expect true or false.

The transition from false -> true is fine, that's making the style unique, going
from true -> false though is not safe since you don't know why the style was
made unique. You're potentially turning on style sharing on a style that
shouldn't have it.