Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2689823002: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, mikecase+watch_chromium.org, agrieve+watch_chromium.org, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, jbudorick+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2689823002 Cr-Commit-Position: refs/heads/master@{#452220} Committed: https://chromium.googlesource.com/chromium/src/+/f66556a43111c2738b0ac3580491fa0c2f1df24f

Patch Set 1 #

Total comments: 2

Patch Set 2 : update compo and team #

Total comments: 2

Patch Set 3 : update compo #

Total comments: 2

Patch Set 4 : add team #

Patch Set 5 : solve merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M build/android/pylib/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/scheduler/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M headless/OWNERS View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/cr/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (20 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-10 21:29:43 UTC) #3
sullivan
https://codereview.chromium.org/2689823002/diff/1/tools/perf/OWNERS File tools/perf/OWNERS (right): https://codereview.chromium.org/2689823002/diff/1/tools/perf/OWNERS#newcode27 tools/perf/OWNERS:27: # COMPONENT: Tools This should be: # COMPONENT: Speed>Benchmarking ...
3 years, 10 months ago (2017-02-10 22:18:12 UTC) #5
ymzhang1
https://codereview.chromium.org/2689823002/diff/1/tools/perf/OWNERS File tools/perf/OWNERS (right): https://codereview.chromium.org/2689823002/diff/1/tools/perf/OWNERS#newcode27 tools/perf/OWNERS:27: # COMPONENT: Tools On 2017/02/10 22:18:12, sullivan wrote: > ...
3 years, 10 months ago (2017-02-10 22:48:16 UTC) #6
sullivan
lgtm lgtm for tools/perf/OWNERS but I am not familiar with the other files in the ...
3 years, 10 months ago (2017-02-10 22:49:29 UTC) #7
ymzhang1
On 2017/02/10 22:49:29, sullivan wrote: > lgtm > > lgtm for tools/perf/OWNERS but I am ...
3 years, 10 months ago (2017-02-10 22:54:54 UTC) #8
jbudorick
https://codereview.chromium.org/2689823002/diff/20001/build/android/pylib/OWNERS File build/android/pylib/OWNERS (right): https://codereview.chromium.org/2689823002/diff/20001/build/android/pylib/OWNERS#newcode6 build/android/pylib/OWNERS:6: # COMPONENT: Build This component should be Test>Android, like ...
3 years, 10 months ago (2017-02-13 14:20:22 UTC) #10
ymzhang1
https://codereview.chromium.org/2689823002/diff/20001/build/android/pylib/OWNERS File build/android/pylib/OWNERS (right): https://codereview.chromium.org/2689823002/diff/20001/build/android/pylib/OWNERS#newcode6 build/android/pylib/OWNERS:6: # COMPONENT: Build On 2017/02/13 14:20:22, jbudorick wrote: > ...
3 years, 10 months ago (2017-02-13 17:46:12 UTC) #11
Sami
https://codereview.chromium.org/2689823002/diff/40001/headless/OWNERS File headless/OWNERS (right): https://codereview.chromium.org/2689823002/diff/40001/headless/OWNERS#newcode5 headless/OWNERS:5: # COMPONENT: Manifest What's "Manifest"? There's no headless component ...
3 years, 10 months ago (2017-02-13 18:41:31 UTC) #12
ymzhang1
https://codereview.chromium.org/2689823002/diff/40001/headless/OWNERS File headless/OWNERS (right): https://codereview.chromium.org/2689823002/diff/40001/headless/OWNERS#newcode5 headless/OWNERS:5: # COMPONENT: Manifest On 2017/02/13 18:41:31, Sami wrote: > ...
3 years, 10 months ago (2017-02-13 18:54:10 UTC) #13
Sami
Thanks, lgtm.
3 years, 10 months ago (2017-02-14 14:25:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689823002/60001
3 years, 10 months ago (2017-02-14 17:33:01 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/153199) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-14 17:35:19 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689823002/60001
3 years, 10 months ago (2017-02-14 17:43:02 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/154894) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-14 17:46:03 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689823002/80001
3 years, 10 months ago (2017-02-18 00:25:44 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 02:28:58 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689823002/80001
3 years, 10 months ago (2017-02-22 18:04:33 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/215724)
3 years, 10 months ago (2017-02-22 18:27:19 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689823002/80001
3 years, 10 months ago (2017-02-22 20:59:17 UTC) #37
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 21:47:32 UTC) #40
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f66556a43111c2738b0ac3580491...

Powered by Google App Engine
This is Rietveld 408576698