Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2689733002: Skip box shadows when printing (Closed)

Created:
3 years, 10 months ago by f(malita)
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, hal canary at chromium, reed1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip box shadows when printing Skia's PDF backend lacks support for mask filters, and currently draws solid black boxes. Skip shadows when printing, while that gets resolved. BUG=127651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2689733002 Cr-Commit-Position: refs/heads/master@{#449661} Committed: https://chromium.googlesource.com/chromium/src/+/698a09b008f29b551de793864a045f2ff0578857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
f(malita)
3 years, 10 months ago (2017-02-10 16:50:35 UTC) #6
chrishtr
lgtm
3 years, 10 months ago (2017-02-10 17:39:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689733002/1
3 years, 10 months ago (2017-02-10 17:57:22 UTC) #11
pdr.
On 2017/02/10 at 17:57:22, commit-bot wrote: > CQ is trying da patch. Follow status at ...
3 years, 10 months ago (2017-02-10 17:59:01 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 18:13:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/698a09b008f29b551de793864a04...

Powered by Google App Engine
This is Rietveld 408576698