Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 2689733002: Skip box shadows when printing (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
index 355c45b9d2950dd85e890980b58dfbf2854a7db7..f0bae739267c1165bbb5709273a2f1faae16d047 100644
--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
@@ -919,6 +919,11 @@ void BoxPainter::paintNormalBoxShadow(const PaintInfo& info,
if (!style.boxShadow())
return;
GraphicsContext& context = info.context;
+
+ // https://bugs.chromium.org/p/skia/issues/detail?id=237
+ if (context.printing())
+ return;
+
FloatRoundedRect border = style.getRoundedBorderFor(
paintRect, includeLogicalLeftEdge, includeLogicalRightEdge);
@@ -1041,6 +1046,10 @@ void BoxPainter::paintInsetBoxShadowInBounds(const PaintInfo& info,
DCHECK(style.boxShadow());
GraphicsContext& context = info.context;
+ // https://bugs.chromium.org/p/skia/issues/detail?id=237
+ if (context.printing())
+ return;
+
bool isHorizontal = style.isHorizontalWritingMode();
GraphicsContextStateSaver stateSaver(context, false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698