IDL compiler: remove special case capitalization (cssText, xmllang, xmlbase, xmlspace)

IDL compiler: remove special case capitalization (cssText, xmllang, xmlbase, xmlspace)

There are a few capitalization exceptions in the IDL compiler for setter names.
They are inconsistent and brittle; this removes them, simplifying the compiler.

This is just a bindings change, so setter names are now correctly capitalized,
e.g., setCssText => setCSSText.
(This does not change IDL files; they have capitalization as in standard.)

2 cases:
1. CssText => CSSText (for attribute cssText) is straightforward; various uses.
2. XML exceptions (Xmllang => XMLlang, Xmlbase => XMLbase, Xmlspace => XMLspace)
are a few exceptions for lowercase attributes, e.g.,
SVGElement.idl has attribute |xmllang| (for xml:lang), not *|xmlLang|.

BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159856

[Nils Barth (inactive), 2013-10-17 06:59:07]

Fixes "remove special cases" FIXME!

[eseidel, 2013-10-17 07:02:19]

So long as this is not changing any exposed methods or causing our internal ones
to widely deviate from the idl, lgtm.

https://codereview.chromium.org/26896005/diff/1/Source/core/svg/SVGLangSpace.cpp
File Source/core/svg/SVGLangSpace.cpp (right):

https://codereview.chromium.org/26896005/diff/1/Source/core/svg/SVGLangSpace....
Source/core/svg/SVGLangSpace.cpp:52: setXMLlang(value);
Not setXMLLang?

[Nils Barth (inactive), 2013-10-17 07:11:32]

https://codereview.chromium.org/26896005/diff/1/Source/core/svg/SVGLangSpace.cpp
File Source/core/svg/SVGLangSpace.cpp (right):

https://codereview.chromium.org/26896005/diff/1/Source/core/svg/SVGLangSpace....
Source/core/svg/SVGLangSpace.cpp:52: setXMLlang(value);
On 2013/10/17 07:02:20, eseidel wrote:
> Not setXMLLang?

That's why it got special-cased in the first place (>.<).

The attribute name is 'xmllang', and the cap rule is just
"Uppercase first letter, or acronym if it's an acronym",
which yields setXMLlang (lower).

Everywhere else a lowercase acronym is followed by an uppercase
character, but these 3 SVG attributes (xmllang, from "xml:lang" etc.)
are irregular.

Anyway, the capitalization in this file is inconsistent already,
to bridge the IDL/Blink divide:
.idl and .h have xmllang, so the setter uses *l*ang, not *L*ang,
but you'll notice that a parameter above is xmlLang, following Blink.

[Nils Barth (inactive), 2013-10-17 07:14:42]

On 2013/10/17 07:02:19, eseidel wrote:
> So long as this is not changing any exposed methods or causing our internal
ones
> to widely deviate from the idl, lgtm.

Thanks Eric!
This is internal-only (bindings only), and makes internal ones more consistent.
(We generally use setHTMLFoo internally for the setter for htmlFoo, with a few
exceptions I'm removing here.)

I'll run tests of course to make sure we're not somehow changing behavior
or external interface.

[commit-bot: I haz the power, 2013-10-17 07:41:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26896005/1

[haraken, 2013-10-17 08:55:22]

LGTM

[commit-bot: I haz the power, 2013-10-17 10:47:45]

Change committed as 159856