IDL compiler: remove special case capitalization (cssText, xmllang, xmlbase, xmlspace)

Source/core/svg/SVGLangSpace.cpp

 /*
  * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/svg/SVGLangSpace.h"
 
 #include "XMLNames.h"
 #include "wtf/StdLibExtras.h"
 
 namespace WebCore {
 
-void SVGLangSpace::setXmllang(const AtomicString& xmlLang)
+void SVGLangSpace::setXMLlang(const AtomicString& xmlLang)
 {
     m_lang = xmlLang;
 }
 
 const AtomicString& SVGLangSpace::xmlspace() const
 {
     if (!m_space) {
         DEFINE_STATIC_LOCAL(const AtomicString, defaultString, ("default", AtomicString::ConstructFromLiteral));
         return defaultString;
     }
 
     return m_space;
 }
 
-void SVGLangSpace::setXmlspace(const AtomicString& xmlSpace)
+void SVGLangSpace::setXMLspace(const AtomicString& xmlSpace)
 {
     m_space = xmlSpace;
 }
 
 bool SVGLangSpace::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name.matches(XMLNames::langAttr)) {
-        setXmllang(value);
+        setXMLlang(value);

[eseidel, 2013/10/17 07:02:20]

Not setXMLLang?

[Nils Barth (inactive), 2013/10/17 07:11:33]

That's why it got special-cased in the first place (>.<).

The attribute name is 'xmllang', and the cap rule is just
"Uppercase first letter, or acronym if it's an acronym",
which yields setXMLlang (lower).

Everywhere else a lowercase acronym is followed by an uppercase
character, but these 3 SVG attributes (xmllang, from "xml:lang" etc.)
are irregular.

Anyway, the capitalization in this file is inconsistent already,
to bridge the IDL/Blink divide:
.idl and .h have xmllang, so the setter uses *l*ang, not *L*ang,
but you'll notice that a parameter above is xmlLang, following Blink.

         return true;
     }
     if (name.matches(XMLNames::spaceAttr)) {
-        setXmlspace(value);
+        setXMLspace(value);
         return true;
     }
 
     return false;
 }
 
 bool SVGLangSpace::isKnownAttribute(const QualifiedName& attrName)
 {
     return attrName.matches(XMLNames::langAttr) || attrName.matches(XMLNames::spaceAttr);
 }
 
 void SVGLangSpace::addSupportedAttributes(HashSet<QualifiedName>& supportedAttributes)
 {
     DEFINE_STATIC_LOCAL(AtomicString, xmlPrefix, ("xml", AtomicString::ConstructFromLiteral));
 
     QualifiedName langWithPrefix = XMLNames::langAttr;
     langWithPrefix.setPrefix(xmlPrefix);
     supportedAttributes.add(langWithPrefix);
     supportedAttributes.add(XMLNames::langAttr);
 
     QualifiedName spaceWithPrefix = XMLNames::spaceAttr;
     spaceWithPrefix.setPrefix(xmlPrefix);
     supportedAttributes.add(spaceWithPrefix);
     supportedAttributes.add(XMLNames::spaceAttr);
 }
 
 }