Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 26896005: IDL compiler: remove special case capitalization (cssText, xmllang, xmlbase, xmlspace) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSArrayFunctionValue.h » ('j') | Source/core/svg/SVGLangSpace.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index edf7fcd46472e83876924fdd563250429cc15bbc..59658c1537207dc684403cc72d10211f283ab6e3 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -5963,11 +5963,11 @@ sub FirstLetterToUpperCase
{
my $param = shift;
my $ret = ucfirst($param);
- # xmlEncoding becomes XMLEncoding, but xmlllang becomes Xmllang.
- $ret =~ s/Xml/XML/ if $ret =~ /^Xml[^a-z]/;
- $ret =~ s/Css/CSS/ if $ret =~ /^Css[^T]/; # css -> setCSS, except setCssText.
- $ret =~ s/Ime/IME/ if $ret =~ /^Ime/; # ime -> setIME
- $ret =~ s/Svg/SVG/ if $ret =~ /^Svg/; # svg -> setSVG
+ # Capitalize initial acronym, e.g., xml -> setXML
+ $ret =~ s/Xml/XML/ if $ret =~ /^Xml/;
+ $ret =~ s/Css/CSS/ if $ret =~ /^Css/;
+ $ret =~ s/Ime/IME/ if $ret =~ /^Ime/;
+ $ret =~ s/Svg/SVG/ if $ret =~ /^Svg/;
return $ret;
}
« no previous file with comments | « no previous file | Source/core/css/CSSArrayFunctionValue.h » ('j') | Source/core/svg/SVGLangSpace.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698