|
Add field-initializing constructors to generated mojo structs.
Currently, when creating mojo-generated struct instances, it requires a
multi-step process, e.g.:
FooPtr foo = Foo::New();
foo->bar = bar;
foo->baz = baz;
This leads to helper factory functions of the form:
FooPtr MakeFoo(int bar, int baz) {
FooPtr foo = Foo::New();
foo->bar = bar;
foo->baz = baz;
return foo;
}
with call sites of the form:
FooPtr foo = MakeFoo(bar, baz);
This boilerplate should not be necessary. This CL adds constructors
to generated mojo structs that initialize struct fields, allowing the
simpler:
FooPtr foo = Foo::New(bar, baz);
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2689513003
Cr-Commit-Position: refs/heads/master@{#453494}
Committed: https://chromium.googlesource.com/chromium/src/+/138493453d9928b3b467939da9d19691831e02ba
Total comments: 13
Total comments: 6
Total comments: 2
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+275 lines, -316 lines) |
Patch |
|
M |
cc/ipc/compositor_frame_metadata.typemap
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
cc/ipc/struct_traits_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/common/OWNERS
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
mojo/common/values.typemap
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/lib/native_struct.cc
|
View
|
1
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/struct_ptr.h
|
View
|
1
|
7 chunks |
+19 lines, -34 lines |
0 comments
|
Download
|
|
A |
mojo/public/cpp/bindings/tests/OWNERS
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/equals_unittest.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+5 lines, -13 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/hash_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -14 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/pickle_unittest.cc
|
View
|
|
7 chunks |
+32 lines, -37 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/pickled_types_blink.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/sample_service_unittest.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+7 lines, -27 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/struct_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
16 chunks |
+66 lines, -108 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/test_native_types_blink.typemap
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/test_native_types_chromium.typemap
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/type_conversion_unittest.cc
|
View
|
|
3 chunks |
+5 lines, -15 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/wtf_hash_unittest.cc
|
View
|
|
1 chunk |
+6 lines, -18 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/interfaces/bindings/tests/test_structs.mojom
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generate_type_mappings.py
|
View
|
1
2
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+15 lines, -2 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+20 lines, -15 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_template_definition.tmpl
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl
|
View
|
1
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/tools/bindings/generators/mojom_cpp_generator.py
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+53 lines, -0 lines |
0 comments
|
Download
|
Total messages: 97 (78 generated)
|