mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl - Issue 2689513003: Add field-initializing constructors to generated mojo structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl

Issue 2689513003: Add field-initializing constructors to generated mojo structs. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_template_definition.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl

index 80527a21ce78a514b61a262112585a7914f3d566..b9e416a9f49c7a4b0400846dfec7500cd613aa08 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl

@@ -1,8 +1,6 @@

// static

{{union.name}}Ptr {{union.name}}::New() {

- {{union.name}}Ptr rv;

- mojo::internal::StructHelper<{{union.name}}>::Initialize(&rv);

- return rv;

+ return {{union.name}}Ptr(base::in_place);

}

{{union.name}}::{{union.name}}() {