Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2689473002: Remove ThreadState::collectGarbageForTerminatingThread (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ThreadState::collectGarbageForTerminatingThread It's now unused. Also this CL removes VisitorMarkingMode::ThreadLocalMarking. BUG=671856 Review-Url: https://codereview.chromium.org/2689473002 Cr-Commit-Position: refs/heads/master@{#449260} Committed: https://chromium.googlesource.com/chromium/src/+/d9960f46f78bbe38e99cc083175f830582e8fceb

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -48 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-09 08:10:34 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-09 08:13:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689473002/20001
3 years, 10 months ago (2017-02-09 08:18:20 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 11:41:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9960f46f78bbe38e99cc083175f...

Powered by Google App Engine
This is Rietveld 408576698