Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2689473002: Remove ThreadState::collectGarbageForTerminatingThread (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp
diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
index 7aecd83c3e5cacd6040efddff228bcc4c186bc4b..f8b1a87f53bdb45815cb140f9f4d2e6f32c113d1 100644
--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
@@ -3785,8 +3785,7 @@ TEST(HeapTest, CheckAndMarkPointer) {
{
TestGCScope scope(BlinkGC::HeapPointersOnStack);
ThreadState::GCForbiddenScope gcScope(ThreadState::current());
- Visitor visitor(ThreadState::current(),
- VisitorMarkingMode::ThreadLocalMarking);
+ Visitor visitor(ThreadState::current(), VisitorMarkingMode::GlobalMarking);
EXPECT_TRUE(scope.allThreadsParked()); // Fail the test if we could not
// park all threads.
heap.flushHeapDoesNotContainCache();
@@ -3812,8 +3811,7 @@ TEST(HeapTest, CheckAndMarkPointer) {
{
TestGCScope scope(BlinkGC::HeapPointersOnStack);
ThreadState::GCForbiddenScope gcScope(ThreadState::current());
- Visitor visitor(ThreadState::current(),
- VisitorMarkingMode::ThreadLocalMarking);
+ Visitor visitor(ThreadState::current(), VisitorMarkingMode::GlobalMarking);
EXPECT_TRUE(scope.allThreadsParked());
heap.flushHeapDoesNotContainCache();
for (size_t i = 0; i < objectAddresses.size(); i++) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698