Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2689463002: Replace OnMemoryStateChange() with OnPurgeMemory() in blink (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, loading-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace OnMemoryStateChange() with OnPurgeMemory() in blink This CL is a follow-up CL of crrev.com/2688653002. Purging memory should be done by MemoryCoordinator::onPurgeMemory(). BUG=684287 Review-Url: https://codereview.chromium.org/2689463002 Cr-Commit-Position: refs/heads/master@{#449475} Committed: https://chromium.googlesource.com/chromium/src/+/3a45906d85eec250eb0a5e53771db0f130e0616e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 1 chunk +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
bashi
PTAL
3 years, 10 months ago (2017-02-09 08:25:15 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-09 08:32:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689463002/1
3 years, 10 months ago (2017-02-09 23:00:05 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 23:58:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a45906d85eec250eb0a5e53771d...

Powered by Google App Engine
This is Rietveld 408576698