Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2688653002: Implement OnPurgeMemory callback for RenderThreadImpl (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
haraken, kinuko, tasak
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement OnPurgeMemory callback for RenderThreadImpl We added OnPurgeMemory() callback to MemoryCoordinatorClient so that we can separate memory purging from memory state transition. This CL moves purging logic from OnMemoryStateChange() to OnPurgeMemory() in RenderThreadImpl. BUG=684287 Review-Url: https://codereview.chromium.org/2688653002 Cr-Commit-Position: refs/heads/master@{#449236} Committed: https://chromium.googlesource.com/chromium/src/+/233f65e7e1d46f4c497dd8384531bae054ed835f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +8 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMemoryCoordinator.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebMemoryCoordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
bashi
PTAL
3 years, 10 months ago (2017-02-09 04:26:09 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-09 04:30:11 UTC) #5
kinuko
lgtm for content/ (just saw this going by)
3 years, 10 months ago (2017-02-09 04:55:15 UTC) #6
bashi
On 2017/02/09 04:55:15, kinuko wrote: > lgtm for content/ (just saw this going by) Thanks! ...
3 years, 10 months ago (2017-02-09 07:23:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688653002/1
3 years, 10 months ago (2017-02-09 07:24:05 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 08:36:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/233f65e7e1d46f4c497dd8384531...

Powered by Google App Engine
This is Rietveld 408576698