Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2689283008: [builtins] Move non-i18n String case conversion functions to C++ (Closed)

Created:
3 years, 10 months ago by Dan Ehrenberg
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, petermarshall
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move non-i18n String case conversion functions to C++ BUG=v8:5880 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2689283008 Cr-Commit-Position: refs/heads/master@{#43246} Committed: https://chromium.googlesource.com/v8/v8/+/aeeacdda9b33285e1b445d6f8f44dc47607f91f5

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -225 lines) Patch
M src/bootstrapper.cc View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 2 2 chunks +195 lines, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/i18n.js View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/js/string.js View 1 2 chunks +0 lines, -36 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-strings.cc View 2 chunks +0 lines, -177 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Dan Ehrenberg
3 years, 10 months ago (2017-02-16 11:50:24 UTC) #15
Yang
On 2017/02/16 11:50:24, Dan Ehrenberg wrote: lgtm, assuming the implementation has not changed, just moved.
3 years, 10 months ago (2017-02-16 12:58:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689283008/40001
3 years, 10 months ago (2017-02-16 13:00:02 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 13:01:49 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/aeeacdda9b33285e1b445d6f8f44dc47607...

Powered by Google App Engine
This is Rietveld 408576698