Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: src/js/string.js

Issue 2689283008: [builtins] Move non-i18n String case conversion functions to C++ (Closed)
Patch Set: Fix a typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/i18n.js ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/string.js
diff --git a/src/js/string.js b/src/js/string.js
index de910532f37cba98637ce030330766c983511f55..5992f802016b2e2f1d5af90669c09b29c63ee603 100644
--- a/src/js/string.js
+++ b/src/js/string.js
@@ -106,38 +106,6 @@ function StringSlice(start, end) {
return %_SubString(s, start_i, end_i);
}
-// TODO(littledan): Rewrite these four functions as C++ builtins
-// ECMA-262, 15.5.4.16
-function StringToLowerCaseJS() {
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.toLowerCase");
-
- return %StringToLowerCase(TO_STRING(this));
-}
-
-
-// ECMA-262, 15.5.4.17
-function StringToLocaleLowerCase() {
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.toLocaleLowerCase");
-
- return %StringToLowerCase(TO_STRING(this));
-}
-
-
-// ECMA-262, 15.5.4.18
-function StringToUpperCaseJS() {
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.toUpperCase");
-
- return %StringToUpperCase(TO_STRING(this));
-}
-
-
-// ECMA-262, 15.5.4.19
-function StringToLocaleUpperCase() {
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.toLocaleUpperCase");
-
- return %StringToUpperCase(TO_STRING(this));
-}
-
// ES6 draft, revision 26 (2014-07-18), section B.2.3.2.1
function HtmlEscape(str) {
@@ -325,10 +293,6 @@ utils.InstallFunctions(GlobalString.prototype, DONT_ENUM, [
"repeat", StringRepeat,
"search", StringSearch,
"slice", StringSlice,
- "toLowerCase", StringToLowerCaseJS,
- "toLocaleLowerCase", StringToLocaleLowerCase,
- "toUpperCase", StringToUpperCaseJS,
- "toLocaleUpperCase", StringToLocaleUpperCase,
"link", StringLink,
"anchor", StringAnchor,
« no previous file with comments | « src/js/i18n.js ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698