Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2689233006: Fix bug on Android causing composition underlines to appear in the wrong place (Closed)
Patch Set: Don't change param names Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index 7ea8eddf77aaa70f6038d00a88f883508d7364c3..f019fb6048f74f6eb27bade5f60e366f1e509cce 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -620,7 +620,10 @@ void InputMethodController::setComposition(
return;
}
- addCompositionUnderlines(underlines, baseNode->parentNode(), baseOffset);
+ const PlainTextRange compositionPlainTextRange =
+ PlainTextRange::create(*baseNode->parentNode(), *m_compositionRange);
+ addCompositionUnderlines(underlines, baseNode->parentNode(),
+ compositionPlainTextRange.start());
}
PlainTextRange InputMethodController::createSelectionRangeForSetComposition(
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698