Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2689213003: Evicted frames should immediately unblock dependent CompositorFrames (Closed)

Created:
3 years, 10 months ago by Fady Samuel
Modified:
3 years, 10 months ago
Reviewers:
kylechar, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Evicted frames should immediately unblock dependent CompositorFrames Prior to this CL, if a Surface is evicted, we would not immediately unblock its dependent Surfaces. This causes parent Frames to block until the deadline hits. This can cause unnecessary jank during cross- process navigation and may cause the browser UI to become unresponsive briefly. This CL immediately unblocks the parent CompositorFrame if the child Surface is evicted. Note that this CL is a pre-requisite to allowing SurfaceFactory to always observe its current Surface, which is necessary so that it is informed when referenced surfaces change and can tell its client to update its reference tracking. This allows the garbage collection system to immediately garbage collect surfaces that are no longer referenced from a parent Surface once a pending frame has replaced an existing active frame. That change is coming in a subsequent CL. BUG=689725 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2689213003 Cr-Commit-Position: refs/heads/master@{#450165} Committed: https://chromium.googlesource.com/chromium/src/+/2d9cf213310be917ade1a3f21d665fc0511e1e10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Fady Samuel
+vmpstr@ for review +kylechar@ FYI
3 years, 10 months ago (2017-02-13 21:07:20 UTC) #3
vmpstr
lgtm
3 years, 10 months ago (2017-02-13 22:21:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689213003/1
3 years, 10 months ago (2017-02-13 22:24:07 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 00:10:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d9cf213310be917ade1a3f21d66...

Powered by Google App Engine
This is Rietveld 408576698