Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: cc/surfaces/surface_dependency_tracker.cc

Issue 2689213003: Evicted frames should immediately unblock dependent CompositorFrames (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/compositor_frame_sink_support_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_dependency_tracker.cc
diff --git a/cc/surfaces/surface_dependency_tracker.cc b/cc/surfaces/surface_dependency_tracker.cc
index df201520f458dd5f6cac01f82445d1eec440b407..d219190306ab4aa3af2eaa880ea51cbc9734f69c 100644
--- a/cc/surfaces/surface_dependency_tracker.cc
+++ b/cc/surfaces/surface_dependency_tracker.cc
@@ -115,10 +115,9 @@ void SurfaceDependencyTracker::OnSurfaceDiscarded(Surface* surface) {
pending_surfaces_.erase(surface);
surface->RemoveObserver(this);
- // TODO(fsamuel): We should consider removing this surface as a dependency on
- // other surfaces. This dependency will be removed when the deadline hits
- // anyway but maybe we should try to actiate these frames early (see
- // https://crbug.com/689725).
+ // Pretend that the discarded surface's SurfaceId is now available to unblock
+ // dependencies because we now know the surface will never activate.
+ NotifySurfaceIdAvailable(surface->surface_id());
}
void SurfaceDependencyTracker::OnSurfaceActivated(Surface* surface) {
« no previous file with comments | « cc/surfaces/compositor_frame_sink_support_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698