Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2689143002: ash: Remove OS_CHROMEOS ifdefs from accelerator files (Closed)

Created:
3 years, 10 months ago by James Cook
Modified:
3 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove OS_CHROMEOS ifdefs from accelerator files Ash used to build on Windows but now only builds on Chrome OS. It does't need OS_CHROMEOS ifdefs anymore. This removes the last ifdefs from src/ash. BUG=666773 TEST=compiles, ash_unittests Review-Url: https://codereview.chromium.org/2689143002 Cr-Commit-Position: refs/heads/master@{#450022} Committed: https://chromium.googlesource.com/chromium/src/+/6ed406b794156c16f82ba5d76776381acaeb8f33

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -477 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 13 chunks +49 lines, -68 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/accelerators/magnifier_key_scroller.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 15 chunks +110 lines, -130 lines 0 comments Download
M ash/common/accelerators/accelerator_router.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/common/accelerators/accelerator_table.h View 6 chunks +34 lines, -40 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 15 chunks +58 lines, -98 lines 0 comments Download
M ash/common/accelerators/accelerator_table_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/common/accelerators/debug_commands.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M ash/common/accelerators/exit_warning_handler.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 6 chunks +1 line, -8 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 6 chunks +31 lines, -49 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_unittest.cc View 14 chunks +0 lines, -18 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
James Cook
oshima, please take a look. I sorted most of the enums/switches but not the helper ...
3 years, 10 months ago (2017-02-12 22:57:28 UTC) #5
oshima
lgtm++!
3 years, 10 months ago (2017-02-12 23:08:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689143002/20001
3 years, 10 months ago (2017-02-13 17:38:58 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 18:31:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ed406b794156c16f82ba5d76776...

Powered by Google App Engine
This is Rietveld 408576698