Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: ash/common/accelerators/accelerator_table.h

Issue 2689143002: ash: Remove OS_CHROMEOS ifdefs from accelerator files (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/accelerators/accelerator_router.cc ('k') | ash/common/accelerators/accelerator_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/accelerators/accelerator_table.h
diff --git a/ash/common/accelerators/accelerator_table.h b/ash/common/accelerators/accelerator_table.h
index ff2817b800dde7428a7215d499c489b96406305d..86a4e0d1f8bea3e31b2c5e0d75c5c4cb967c719f 100644
--- a/ash/common/accelerators/accelerator_table.h
+++ b/ash/common/accelerators/accelerator_table.h
@@ -52,22 +52,33 @@ namespace ash {
// Please put if/def sections at the end of the bare section and keep the list
// within each section in alphabetical order.
enum AcceleratorAction {
+ BRIGHTNESS_DOWN,
+ BRIGHTNESS_UP,
CYCLE_BACKWARD_MRU,
CYCLE_FORWARD_MRU,
DEBUG_PRINT_LAYER_HIERARCHY,
DEBUG_PRINT_VIEW_HIERARCHY,
DEBUG_PRINT_WINDOW_HIERARCHY,
+ DEBUG_SHOW_TOAST,
DEBUG_TOGGLE_DEVICE_SCALE_FACTOR,
DEBUG_TOGGLE_SHOW_DEBUG_BORDERS,
DEBUG_TOGGLE_SHOW_FPS_COUNTER,
DEBUG_TOGGLE_SHOW_PAINT_RECTS,
+ DEBUG_TOGGLE_TOUCH_PAD,
+ DEBUG_TOGGLE_TOUCH_SCREEN,
+ DEBUG_TOGGLE_TOUCH_VIEW,
DEBUG_TOGGLE_WALLPAPER_MODE,
DEBUG_TRIGGER_CRASH, // Intentionally crash the ash process.
+ DEV_ADD_REMOVE_DISPLAY,
DEV_TOGGLE_ROOT_WINDOW_FULL_SCREEN,
+ DEV_TOGGLE_UNIFIED_DESKTOP,
+ DISABLE_CAPS_LOCK,
EXIT,
FOCUS_NEXT_PANE,
FOCUS_PREVIOUS_PANE,
FOCUS_SHELF,
+ KEYBOARD_BRIGHTNESS_DOWN,
+ KEYBOARD_BRIGHTNESS_UP,
LAUNCH_APP_0,
LAUNCH_APP_1,
LAUNCH_APP_2,
@@ -77,6 +88,9 @@ enum AcceleratorAction {
LAUNCH_APP_6,
LAUNCH_APP_7,
LAUNCH_LAST_APP,
+ LOCK_PRESSED,
+ LOCK_RELEASED,
+ LOCK_SCREEN,
MAGNIFY_SCREEN_ZOOM_IN,
MAGNIFY_SCREEN_ZOOM_OUT,
MEDIA_NEXT_TRACK,
@@ -86,7 +100,12 @@ enum AcceleratorAction {
NEW_TAB,
NEW_WINDOW,
NEXT_IME,
+ OPEN_CROSH,
OPEN_FEEDBACK_PAGE,
+ OPEN_FILE_MANAGER,
+ OPEN_GET_HELP,
+ POWER_PRESSED,
+ POWER_RELEASED,
PREVIOUS_IME,
PRINT_UI_HIERARCHIES,
RESTORE_TAB,
@@ -95,63 +114,40 @@ enum AcceleratorAction {
SCALE_UI_DOWN,
SCALE_UI_RESET,
SCALE_UI_UP,
+ SHOW_IME_MENU_BUBBLE,
SHOW_KEYBOARD_OVERLAY,
SHOW_MESSAGE_CENTER_BUBBLE,
+ SHOW_STYLUS_TOOLS,
SHOW_SYSTEM_TRAY_BUBBLE,
SHOW_TASK_MANAGER,
- SWITCH_IME, // Switch to another IME depending on the accelerator.
- TAKE_WINDOW_SCREENSHOT,
- TAKE_PARTIAL_SCREENSHOT,
- TAKE_SCREENSHOT,
- TOGGLE_APP_LIST,
- TOGGLE_FULLSCREEN,
- TOGGLE_MAXIMIZED,
- TOGGLE_OVERVIEW,
- UNPIN,
- WINDOW_MINIMIZE,
- WINDOW_POSITION_CENTER,
- WINDOW_CYCLE_SNAP_DOCK_LEFT,
- WINDOW_CYCLE_SNAP_DOCK_RIGHT,
-#if defined(OS_CHROMEOS)
- BRIGHTNESS_DOWN,
- BRIGHTNESS_UP,
- DEBUG_SHOW_TOAST,
- DEBUG_TOGGLE_TOUCH_PAD,
- DEBUG_TOGGLE_TOUCH_SCREEN,
- DEBUG_TOGGLE_TOUCH_VIEW,
- DEV_ADD_REMOVE_DISPLAY,
- DEV_TOGGLE_UNIFIED_DESKTOP,
- DISABLE_CAPS_LOCK,
- KEYBOARD_BRIGHTNESS_DOWN,
- KEYBOARD_BRIGHTNESS_UP,
- LOCK_PRESSED,
- LOCK_RELEASED,
- LOCK_SCREEN,
- OPEN_CROSH,
- OPEN_FILE_MANAGER,
- OPEN_GET_HELP,
- POWER_PRESSED,
- POWER_RELEASED,
- SHOW_IME_MENU_BUBBLE,
SUSPEND,
- SHOW_STYLUS_TOOLS,
SWAP_PRIMARY_DISPLAY,
+ SWITCH_IME, // Switch to another IME depending on the accelerator.
SWITCH_TO_NEXT_USER,
SWITCH_TO_PREVIOUS_USER,
+ TAKE_PARTIAL_SCREENSHOT,
+ TAKE_SCREENSHOT,
+ TAKE_WINDOW_SCREENSHOT,
+ TOGGLE_APP_LIST,
TOGGLE_CAPS_LOCK,
+ TOGGLE_FULLSCREEN,
TOGGLE_HIGH_CONTRAST,
+ TOGGLE_MAXIMIZED,
TOGGLE_MIRROR_MODE,
+ TOGGLE_OVERVIEW,
TOGGLE_SPOKEN_FEEDBACK,
TOGGLE_WIFI,
TOUCH_HUD_CLEAR,
TOUCH_HUD_MODE_CHANGE,
TOUCH_HUD_PROJECTION_TOGGLE,
+ UNPIN,
VOLUME_DOWN,
VOLUME_MUTE,
VOLUME_UP,
-#else
- DUMMY_FOR_RESERVED,
-#endif
+ WINDOW_CYCLE_SNAP_DOCK_LEFT,
+ WINDOW_CYCLE_SNAP_DOCK_RIGHT,
+ WINDOW_MINIMIZE,
+ WINDOW_POSITION_CENTER,
};
struct AcceleratorData {
@@ -197,7 +193,6 @@ enum DeprecatedAcceleratorUsage {
ASH_EXPORT extern const AcceleratorData kAcceleratorData[];
ASH_EXPORT extern const size_t kAcceleratorDataLength;
-#if defined(OS_CHROMEOS)
// The list of the deprecated accelerators.
ASH_EXPORT extern const AcceleratorData kDeprecatedAccelerators[];
ASH_EXPORT extern const size_t kDeprecatedAcceleratorsLength;
@@ -206,7 +201,6 @@ ASH_EXPORT extern const size_t kDeprecatedAcceleratorsLength;
// handle them.
ASH_EXPORT extern const DeprecatedAcceleratorData kDeprecatedAcceleratorsData[];
ASH_EXPORT extern const size_t kDeprecatedAcceleratorsDataLength;
-#endif // defined(OS_CHROMEOS)
// Debug accelerators. Debug accelerators are only enabled when the "Debugging
// keyboard shortcuts" flag (--ash-debug-shortcuts) is enabled. Debug actions
« no previous file with comments | « ash/common/accelerators/accelerator_router.cc ('k') | ash/common/accelerators/accelerator_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698