[Web Agents API]: Start fleshing out generated code.

[Web Agents API]: Start fleshing out generated code.

A whole bunch of small tweaks:
* Started using proper paths in includes.
* Added constructor/factory methods.
* Modified the handling of inheritance to fit reality.
* Made all paths and macro guards ready to build.

This almost compiles into something :)

R=bashi,yuki,haraken
BUG=683743
Review-Url: https://codereview.chromium.org/2688933003
Cr-Commit-Position: refs/heads/master@{#449882}
Committed: https://chromium.googlesource.com/chromium/src/+/feab6985ba849044d3acc1d6fa7d5904c6db3f8a

[dglazkov, 2017-02-11 00:40:53]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 00:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-02-11 00:45:42]

Description was changed from

==========
[Web Agents API]: Start fleshing out generated code.

A whole bunch of small tweaks:
* Started using proper paths in includes
* Added constructor/factory methods
* Modified the handling of inheritance to fit reality.
* Made all paths and macro guards ready to build.

This almost compiles into something :)

R=bashi,yuki,haraken
BUG=683743
==========

to

==========
[Web Agents API]: Start fleshing out generated code.

A whole bunch of small tweaks:
* Started using proper paths in includes.
* Added constructor/factory methods.
* Modified the handling of inheritance to fit reality.
* Made all paths and macro guards ready to build.

This almost compiles into something :)

R=bashi,yuki,haraken
BUG=683743
==========

[dglazkov, 2017-02-11 00:53:27]

Moar cleanup.

[dglazkov, 2017-02-11 00:53:28]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 00:53:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-02-11 01:51:18]

PTAL.

[commit-bot: I haz the power, 2017-02-11 06:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 06:54:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2017-02-11 09:56:46]

LGTM

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py:32:
OILPAN_INCLUDE_PATH = 'platform/heap/Handle.h'

BLINK_GC_INCLUDE_PATH

Oilpan is a project name and we normally avoid writing it in the code base
(except comments).

However, I'm not sure how helpful the macro is. We could just write
''platform/heap/Handle.h' on the call sites.

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl:19:
blink::GarbageCollectedFinalized<{{class_name.upper_camel_case}}>

I'm not sure if this needs to be 'Finalized'. If the class only has a Member to
the C++ object, a finalizer wouldn't be needed.

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl:29:
DECLARE_STATIC();

What is this for?

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc:21:
TestInterface3* TestInterface3::Create(blink::TestInterface3* test_interface_3)
{

Can test_interface_3 be null? It looks a bit strange that a Create method can
return nullptr.

[Tomnow220889, 2017-02-11 10:41:10]

tomnow220889@gmail.com changed reviewers:
+ Tomnow220889@gmail.com

[dglazkov, 2017-02-11 21:55:04]

Addressed feedback.

[dglazkov, 2017-02-11 21:55:05]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 21:55:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-02-11 21:56:20]

dglazkov@chromium.org changed reviewers:
+ tomnow220889@gmail.com
- Tomnow220889@gmail.com

[dglazkov, 2017-02-11 21:56:21]

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py:32:
OILPAN_INCLUDE_PATH = 'platform/heap/Handle.h'
On 2017/02/11 at 09:56:46, haraken wrote:
> BLINK_GC_INCLUDE_PATH
> 
> Oilpan is a project name and we normally avoid writing it in the code base
(except comments).
> 
> However, I'm not sure how helpful the macro is. We could just write
''platform/heap/Handle.h' on the call sites.

Good point. Incorporated inline.

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl:19:
blink::GarbageCollectedFinalized<{{class_name.upper_camel_case}}>
On 2017/02/11 at 09:56:46, haraken wrote:
> I'm not sure if this needs to be 'Finalized'. If the class only has a Member
to the C++ object, a finalizer wouldn't be needed.

Oh! Thanks for the tip. Changed.

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl:29:
DECLARE_STATIC();
On 2017/02/11 at 09:56:46, haraken wrote:
> What is this for?

That's... a booger :D

I meant to type DECLARE_TRACE, but that's what came out instead. Fixed.

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
(right):

https://codereview.chromium.org/2688933003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc:21:
TestInterface3* TestInterface3::Create(blink::TestInterface3* test_interface_3)
{
On 2017/02/11 at 09:56:46, haraken wrote:
> Can test_interface_3 be null? It looks a bit strange that a Create method can
return nullptr.

Yeah, that's the main reason I ended up using factories instead of just plain
constructors. The objects these wrappers wrap often could be 0 and seemed more
convenient to accommodate this in the factory, rather than do null-checking
inline. For example, in https://codereview.chromium.org/2591803002:

Element* Element::GetFirstElementChild() const {
  return Element::Create(blink::ParentNode::firstElementChild(*element()));
}

the firstElementChild could be nullptr, but I don't need to do anything special
when generating this code. Instead, the factory makes sure to return a nullptr
instead of a wrapper that holds a nullptr.

[commit-bot: I haz the power, 2017-02-11 23:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:31:02]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-02-11 23:31:46]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2017-02-11 23:31:47]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2688933003/#ps40001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2017-02-11 23:32:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 23:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:37:42]

Failed to apply patch for
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc:10
  error:
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc: patch
does not apply

Patch:      
third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
Index: third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
diff --git
a/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
b/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
index
a5517c8352701a25eef4aad384779bf8b1183a51..201be68c3ec98d3e9703ab3f7e48c9d2433f6fe4
100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
+++ b/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
@@ -10,17 +10,23 @@
 
 // clang-format off
 
-#include "test_interface_3.h"
+#include "web/api/test_interface_3.h"
 
-// TODO(dglazkov): Implement generating includes.
-#include "wtf/text/WTFString.h.h"
+// TODO(dglazkov): Properly sort the includes.
+#include "wtf/text/WTFString.h"
+#include "bindings/tests/idls/core/TestInterface3.h"
 
-namespace blink {
-namespace api {
+namespace web {
 
-// TODO(dglazkov): Implement constant generation
+TestInterface3* TestInterface3::Create(blink::TestInterface3* test_interface_3)
{
+  return test_interface_3 ? new TestInterface3(test_interface_3) : nullptr;
+}
+
+DEFINE_TRACE(TestInterface3) {
+  visitor->trace(test_interface_3_);
+}
 
-// TODO(dglazkov): Implement constructor generation
+// TODO(dglazkov): Implement constant generation
 
 // TODO(dglazkov): Implement attribute getter/setter generation
 // DOMString readonlyStringifierAttribute
@@ -28,5 +34,11 @@ namespace api {
 // TODO(dglazkov): Implement method generation
 // void TestInterface3::voidMethodDocument
 
-}  // namespace api
-}  // namespace blink
+TestInterface3::TestInterface3(blink::TestInterface3* test_interface_3)
+    : test_interface_3_(test_interface_3) {}
+
+blink::TestInterface3* TestInterface3::test_interface_3() const {
+  return test_interface_3_;
+}
+
+}  // namespace web

[dglazkov, 2017-02-12 00:46:39]

Rebased.

[dglazkov, 2017-02-12 00:46:40]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 00:46:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 01:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 01:57:56]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-02-12 02:14:55]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2017-02-12 02:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2688933003/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-02-12 02:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 02:19:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486865695069020,
"parent_rev": "6cc15b2c2eb82ac455cd7dbfe912be9914c1c03d", "commit_rev":
"feab6985ba849044d3acc1d6fa7d5904c6db3f8a"}

[commit-bot: I haz the power, 2017-02-12 02:20:01]

Description was changed from

==========
[Web Agents API]: Start fleshing out generated code.

A whole bunch of small tweaks:
* Started using proper paths in includes.
* Added constructor/factory methods.
* Modified the handling of inheritance to fit reality.
* Made all paths and macro guards ready to build.

This almost compiles into something :)

R=bashi,yuki,haraken
BUG=683743
==========

to

==========
[Web Agents API]: Start fleshing out generated code.

A whole bunch of small tweaks:
* Started using proper paths in includes.
* Added constructor/factory methods.
* Modified the handling of inheritance to fit reality.
* Made all paths and macro guards ready to build.

This almost compiles into something :)

R=bashi,yuki,haraken
BUG=683743

Review-Url: https://codereview.chromium.org/2688933003
Cr-Commit-Position: refs/heads/master@{#449882}
Committed:
https://chromium.googlesource.com/chromium/src/+/feab6985ba849044d3acc1d6fa7d...
==========

[commit-bot: I haz the power, 2017-02-12 02:20:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/feab6985ba849044d3acc1d6fa7d...