Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl

Issue 2688933003: [Web Agents API]: Start fleshing out generated code. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl b/third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl
index b86dc511e8b79cc9e4f0026bcb01a708b83b4ffe..3bcfc3e687d4d6c327991a91795d6fdcf920b4b1 100644
--- a/third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl
@@ -2,23 +2,30 @@
{% include 'copyright_block.txt' %}
-#include "{{class_name.snake_case}}.h"
+#include "web/api/{{class_name.snake_case}}.h"
-// TODO(dglazkov): Implement generating includes.
+// TODO(dglazkov): Properly sort the includes.
{% for filename in cpp_includes %}
-#include "{{filename}}.h"
+#include "{{filename}}"
{% endfor %}
-namespace blink {
-namespace api {
+namespace web {
+
+{{class_name.upper_camel_case}}* {{class_name.upper_camel_case}}::Create(blink::{{class_name.upper_camel_case}}* {{class_name.snake_case}}) {
+ return {{class_name.snake_case}} ? new {{class_name.upper_camel_case}}({{class_name.snake_case}}) : nullptr;
+}
+
+{% if not base_class %}
+DEFINE_TRACE({{class_name.upper_camel_case}}) {
+ visitor->trace({{class_name.snake_case}}_);
+}
+{% endif %}
// TODO(dglazkov): Implement constant generation
{% for constant in constants %}
// {{ constant.name }}
{% endfor %}
-// TODO(dglazkov): Implement constructor generation
-
// TODO(dglazkov): Implement attribute getter/setter generation
{% for attribute in attributes %}
// {{attribute.return_type}} {{attribute.name}}
@@ -29,7 +36,13 @@ namespace api {
// {{method.return_type}} {{class_name.upper_camel_case}}::{{method.name}}
{% endfor %}
-} // namespace api
-} // namespace blink
+{{class_name.upper_camel_case}}::{{class_name.upper_camel_case}}(blink::{{class_name.upper_camel_case}}* {{class_name.snake_case}})
+ : {{class_name.snake_case}}_({{class_name.snake_case}}) {}
+
+blink::{{class_name.upper_camel_case}}* {{class_name.upper_camel_case}}::{{class_name.snake_case}}() const {
+ return {{class_name.snake_case}}_;
+}
+
+} // namespace web
{% endfilter %}

Powered by Google App Engine
This is Rietveld 408576698