Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2688623004: Move native_pixmap.h from ui/ozone/public to ui/gfx (Closed)

Created:
3 years, 10 months ago by Julien Isorce
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move native_pixmap.h from ui/ozone/public to ui/gfx Like existing ui/gfx/native_pixmap_handle.h, the file native_pixmap.h is not ozone specific. Pre-step before moving ui/ozone/gl/gl_image_ozone_native_pixmap.cc to ui/gl/gl_image_linux_native_pixmap.cc in order to enable gl::GLImageEGL with EGL_LINUX_DMA_BUF_EXT on linux desktop. BUG=584248 R=reveman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2688623004 Cr-Commit-Position: refs/heads/master@{#454585} Committed: https://chromium.googlesource.com/chromium/src/+/eacee6c8bf6fe847bf6b5b08a260badd7ed64930

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -102 lines) Patch
M components/exo/display_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vaapi_drm_picture.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/gfx/native_pixmap.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/ozone/public/native_pixmap.h View 1 2 1 chunk +0 lines, -81 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (20 generated)
Julien Isorce
On 2017/02/09 15:43:38, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
3 years, 10 months ago (2017-02-21 16:59:39 UTC) #6
reveman
lgtm % dnicoara's review
3 years, 10 months ago (2017-02-23 03:22:59 UTC) #8
dnicoara
lgtm + rjkroege@ for broader Ozone ownership review
3 years, 10 months ago (2017-02-23 16:02:39 UTC) #14
Julien Isorce
On 2017/02/23 16:02:39, dnicoara wrote: > lgtm > > + rjkroege@ for broader Ozone ownership ...
3 years, 10 months ago (2017-02-24 10:29:44 UTC) #17
sandersd (OOO until July 31)
Sorry I missed this one, media/ LGTM.
3 years, 9 months ago (2017-03-02 00:37:29 UTC) #18
Julien Isorce
On 2017/03/02 00:37:29, sandersd (OOO until March 13) wrote: > Sorry I missed this one, ...
3 years, 9 months ago (2017-03-02 15:28:26 UTC) #19
Julien Isorce
Hi rjkroege@ please take a look, thx.
3 years, 9 months ago (2017-03-02 15:29:14 UTC) #20
rjkroege
lgtm
3 years, 9 months ago (2017-03-02 15:37:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688623004/40001
3 years, 9 months ago (2017-03-03 11:26:55 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/377727)
3 years, 9 months ago (2017-03-03 11:32:59 UTC) #26
Julien Isorce
On 2017/03/03 11:32:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-03 11:40:08 UTC) #28
sadrul
lgtm
3 years, 9 months ago (2017-03-03 15:01:08 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688623004/40001
3 years, 9 months ago (2017-03-03 15:08:31 UTC) #31
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 15:12:55 UTC) #34
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eacee6c8bf6fe847bf6b5b08a260...

Powered by Google App Engine
This is Rietveld 408576698